Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ae395f0

Browse filesBrowse files
author
Amit Kapila
committed
Fix the testcase introduced in commit 81d20fb.
The failed test was syncing failover replication slot to standby to test that we remove such slots after the standby is converted to subscriber by pg_createsubscriber. In one of the buildfarm members, the sync of the slot failed because the LSN on the standby was before the syncslot's LSN. We need to wait for standby to catch up before trying to sync the slot with pg_sync_replication_slots(). The other buildfarm failed because autovacuum generated a xid which is replicated to the standby at some random point making slots at primary lag behind standby during slot sync. Both these failures wouldn't have occurred if we had used built-in slotsync worker as it would have waited for the standby to sync with primary but for this test, it is sufficient to use pg_sync_replication_slots(). Reported-by: Alexander Lakhin as per buildfarm Author: Kuroda Hayato Reviewed-by: Amit Kapila Backpatch-through: 17 Discussion: https://postgr.es/m/0dffca12-bf17-4a7a-334d-225569de5e6e@gmail.com Discussion: https://postgr.es/m/OSBPR01MB25528300C71FDD83EA1DCA12F5DD2@OSBPR01MB2552.jpnprd01.prod.outlook.com
1 parent 9fd0252 commit ae395f0
Copy full SHA for ae395f0

File tree

Expand file treeCollapse file tree

1 file changed

+7
-0
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+7
-0
lines changed

‎src/bin/pg_basebackup/t/040_pg_createsubscriber.pl

Copy file name to clipboardExpand all lines: src/bin/pg_basebackup/t/040_pg_createsubscriber.pl
+7Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,10 @@ sub generate_db
116116
my $node_p = PostgreSQL::Test::Cluster->new('node_p');
117117
my $pconnstr = $node_p->connstr;
118118
$node_p->init(allows_streaming => 'logical');
119+
# Disable autovacuum to avoid generating xid during stats update as otherwise
120+
# the new XID could then be replicated to standby at some random point making
121+
# slots at primary lag behind standby during slot sync.
122+
$node_p->append_conf('postgresql.conf', 'autovacuum = off');
119123
$node_p->start;
120124

121125
# Set up node F as about-to-fail node
@@ -293,6 +297,9 @@ sub generate_db
293297
"SELECT pg_create_logical_replication_slot('$fslotname', 'pgoutput', false, false, true)"
294298
);
295299
$node_s->start;
300+
# Wait for the standby to catch up so that the standby is not lagging behind
301+
# the failover slot.
302+
$node_p->wait_for_replay_catchup($node_s);
296303
$node_s->safe_psql('postgres', "SELECT pg_sync_replication_slots()");
297304
my $result = $node_s->safe_psql('postgres',
298305
"SELECT slot_name FROM pg_replication_slots WHERE slot_name = '$fslotname' AND synced AND NOT temporary"

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.