Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit a05dbf4

Browse filesBrowse files
committed
Add GUC_LIST_INPUT and GUC_LIST_QUOTE to unix_socket_directories
This should have been done in the initial commit that made unix_socket_directories a list as of c9b0cbe. This change allows to support correctly the case of ALTER SYSTEM, where it is possible to specify multiple paths as a list, like the following pattern where flattening is applied to each item: ALTER SYSTEM SET unix_socket_directories = '/path1', '/path2'; Any parameters specified in postgresql.conf are parsed the same way, so there is no compatibility change. pg_dump has a hardcoded list of parameters marked with GUC_LIST_QUOTE, that gets its routine update. These are reordered alphabetically for clarity. Author: Ian Lawrence Barwick Reviewed-by: Peter Eisentraunt, Tom Lane, Michael Paquier Discussion: https://postgr.es/m/CAB8KJ=iMOtNY6_sUwV=LQVCJ2zgYHBDyNzVfvE5GN3WQ3v9kQg@mail.gmail.com
1 parent ceaeac5 commit a05dbf4
Copy full SHA for a05dbf4

File tree

Expand file treeCollapse file tree

2 files changed

+5
-4
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+5
-4
lines changed

‎src/backend/utils/misc/guc.c

Copy file name to clipboardExpand all lines: src/backend/utils/misc/guc.c
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4173,7 +4173,7 @@ static struct config_string ConfigureNamesString[] =
41734173
{"unix_socket_directories", PGC_POSTMASTER, CONN_AUTH_SETTINGS,
41744174
gettext_noop("Sets the directories where Unix-domain sockets will be created."),
41754175
NULL,
4176-
GUC_SUPERUSER_ONLY
4176+
GUC_LIST_INPUT | GUC_LIST_QUOTE | GUC_SUPERUSER_ONLY
41774177
},
41784178
&Unix_socket_directories,
41794179
#ifdef HAVE_UNIX_SOCKETS

‎src/bin/pg_dump/dumputils.c

Copy file name to clipboardExpand all lines: src/bin/pg_dump/dumputils.c
+4-3Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -865,11 +865,12 @@ buildACLQueries(PQExpBuffer acl_subquery, PQExpBuffer racl_subquery,
865865
bool
866866
variable_is_guc_list_quote(const char *name)
867867
{
868-
if (pg_strcasecmp(name, "temp_tablespaces") == 0 ||
868+
if (pg_strcasecmp(name, "local_preload_libraries") == 0 ||
869+
pg_strcasecmp(name, "search_path") == 0 ||
869870
pg_strcasecmp(name, "session_preload_libraries") == 0 ||
870871
pg_strcasecmp(name, "shared_preload_libraries") == 0 ||
871-
pg_strcasecmp(name, "local_preload_libraries") == 0 ||
872-
pg_strcasecmp(name, "search_path") == 0)
872+
pg_strcasecmp(name, "temp_tablespaces") == 0 ||
873+
pg_strcasecmp(name, "unix_socket_directories") == 0)
873874
return true;
874875
else
875876
return false;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.