Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 997db12

Browse filesBrowse files
committed
Make GIN test using injection points repeatable
As written, the test would fail when run repeatedly because one of the injection points attached was not detached. This would not matter if the test is rewritten to be concurrently safe, but let's be clean and it is a good practice. Oversight in 6a1ea02. Discussion: https://postgr.es/m/ZfP7IDs9TvrKe49x@paquier.xyz
1 parent 705ec05 commit 997db12
Copy full SHA for 997db12

File tree

Expand file treeCollapse file tree

2 files changed

+8
-0
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+8
-0
lines changed

‎src/test/modules/gin/expected/gin_incomplete_splits.out

Copy file name to clipboardExpand all lines: src/test/modules/gin/expected/gin_incomplete_splits.out
+6Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,3 +179,9 @@ select verify(:next_i);
179179
t
180180
(1 row)
181181

182+
SELECT injection_points_detach('gin-finish-incomplete-split');
183+
injection_points_detach
184+
-------------------------
185+
186+
(1 row)
187+

‎src/test/modules/gin/sql/gin_incomplete_splits.sql

Copy file name to clipboardExpand all lines: src/test/modules/gin/sql/gin_incomplete_splits.sql
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,3 +143,5 @@ select insert_n(:next_i, 10) as next_i
143143
\gset
144144
-- Verify that a scan still works
145145
select verify(:next_i);
146+
147+
SELECT injection_points_detach('gin-finish-incomplete-split');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.