Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 8f136af

Browse filesBrowse files
committed
Use correct datatype for xmin variables in slot.c
Two variables storing a slot's effective_xmin and effective_catalog_xmin were saved as XLogRecPtr, which is incorrect as these should be TransactionIds. Oversight in 818fefd. Author: Bharath Rupireddy Discussion: https://postgr.es/m/CALj2ACVPSB74mrDTFezz-LV3Oi6F3SN71QA0oUHvndzi5dwTNg@mail.gmail.com Backpatch-through: 16
1 parent 810f64a commit 8f136af
Copy full SHA for 8f136af

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed

‎src/backend/replication/slot.c

Copy file name to clipboardExpand all lines: src/backend/replication/slot.c
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1545,8 +1545,8 @@ InvalidatePossiblyObsoleteSlot(ReplicationSlotInvalidationCause cause,
15451545
int last_signaled_pid = 0;
15461546
bool released_lock = false;
15471547
bool terminated = false;
1548-
XLogRecPtr initial_effective_xmin = InvalidXLogRecPtr;
1549-
XLogRecPtr initial_catalog_effective_xmin = InvalidXLogRecPtr;
1548+
TransactionId initial_effective_xmin = InvalidTransactionId;
1549+
TransactionId initial_catalog_effective_xmin = InvalidTransactionId;
15501550
XLogRecPtr initial_restart_lsn = InvalidXLogRecPtr;
15511551
ReplicationSlotInvalidationCause invalidation_cause_prev PG_USED_FOR_ASSERTS_ONLY = RS_INVAL_NONE;
15521552

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.