Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 70a7732

Browse filesBrowse files
tglsfdctglsfdc
committed
Remove support for upgrading extensions from "unpackaged" state.
Andres Freund pointed out that allowing non-superusers to run "CREATE EXTENSION ... FROM unpackaged" has security risks, since the unpackaged-to-1.0 scripts don't try to verify that the existing objects they're modifying are what they expect. Just attaching such objects to an extension doesn't seem too dangerous, but some of them do more than that. We could have resolved this, perhaps, by still requiring superuser privilege to use the FROM option. However, it's fair to ask just what we're accomplishing by continuing to lug the unpackaged-to-1.0 scripts forward. None of them have received any real testing since 9.1 days, so they may not even work anymore (even assuming that one could still load the previous "loose" object definitions into a v13 database). And an installation that's trying to go from pre-9.1 to v13 or later in one jump is going to have worse compatibility problems than whether there's a trivial way to convert their contrib modules into extension style. Hence, let's just drop both those scripts and the core-code support for "CREATE EXTENSION ... FROM". Discussion: https://postgr.es/m/20200213233015.r6rnubcvl4egdh5r@alap3.anarazel.de
1 parent 2f9c46a commit 70a7732
Copy full SHA for 70a7732

File tree

Expand file treeCollapse file tree

84 files changed

+55
-2428
lines changed
Filter options

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Dismiss banner
Expand file treeCollapse file tree

84 files changed

+55
-2428
lines changed

‎contrib/btree_gin/Makefile

Copy file name to clipboardExpand all lines: contrib/btree_gin/Makefile
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ OBJS = \
77

88
EXTENSION = btree_gin
99
DATA = btree_gin--1.0.sql btree_gin--1.0--1.1.sql btree_gin--1.1--1.2.sql \
10-
btree_gin--1.2--1.3.sql btree_gin--unpackaged--1.0.sql
10+
btree_gin--1.2--1.3.sql
1111
PGFILEDESC = "btree_gin - B-tree equivalent GIN operator classes"
1212

1313
REGRESS = install_btree_gin int2 int4 int8 float4 float8 money oid \

‎contrib/btree_gin/btree_gin--unpackaged--1.0.sql

Copy file name to clipboardExpand all lines: contrib/btree_gin/btree_gin--unpackaged--1.0.sql
-119Lines changed: 0 additions & 119 deletions
This file was deleted.

‎contrib/btree_gist/Makefile

Copy file name to clipboardExpand all lines: contrib/btree_gist/Makefile
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ OBJS = \
2929
btree_uuid.o
3030

3131
EXTENSION = btree_gist
32-
DATA = btree_gist--unpackaged--1.0.sql btree_gist--1.0--1.1.sql \
32+
DATA = btree_gist--1.0--1.1.sql \
3333
btree_gist--1.1--1.2.sql btree_gist--1.2.sql btree_gist--1.2--1.3.sql \
3434
btree_gist--1.3--1.4.sql btree_gist--1.4--1.5.sql
3535
PGFILEDESC = "btree_gist - B-tree equivalent GiST operator classes"

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.