Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 6819b90

Browse filesBrowse files
committed
pgbench: Remove dead code
doConnect() never returns connections in state CONNECTION_BAD, so checking for that is pointless. Remove the code that does. This code has been dead since ba708ea, 20 years ago. Discussion: https://postgr.es/m/20210126195224.GA20361@alvherre.pgsql Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
1 parent b034ef9 commit 6819b90
Copy full SHA for 6819b90

File tree

Expand file treeCollapse file tree

1 file changed

+0
-7
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-7
lines changed

‎src/bin/pgbench/pgbench.c

Copy file name to clipboardExpand all lines: src/bin/pgbench/pgbench.c
-7Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6040,13 +6040,6 @@ main(int argc, char **argv)
60406040
if (con == NULL)
60416041
exit(1);
60426042

6043-
if (PQstatus(con) == CONNECTION_BAD)
6044-
{
6045-
pg_log_fatal("connection to database \"%s\" failed: %s",
6046-
dbName, PQerrorMessage(con));
6047-
exit(1);
6048-
}
6049-
60506043
if (internal_script_used)
60516044
GetTableInfo(con, scale_given);
60526045

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.