Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 629520b

Browse filesBrowse files
committed
Fix comment in libpqrcv_check_conninfo().
Previously, the comment incorrectly stated that libpqrcv_check_conninfo() returns true or false based on the connection string check. However, this function actually has a void return type and raises an error if the check fails. Author: Rintaro Ikeda Reviewed-by: Jelte Fennema-Nio, Fujii Masao Discussion: https://postgr.es/m/6a1ca81b27fec4da0ccdfaaaec787982@oss.nttdata.com
1 parent ca481d3 commit 629520b
Copy full SHA for 629520b

File tree

Expand file treeCollapse file tree

1 file changed

+4
-4
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-4
lines changed

‎src/backend/replication/libpqwalreceiver/libpqwalreceiver.c

Copy file name to clipboardExpand all lines: src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -305,12 +305,12 @@ libpqrcv_connect(const char *conninfo, bool replication, bool logical,
305305
}
306306

307307
/*
308-
* Validate connection info string, and determine whether it might cause
309-
* local filesystem access to be attempted.
308+
* Validate connection info string.
310309
*
311310
* If the connection string can't be parsed, this function will raise
312-
* an error and will not return. If it can, it will return true if this
313-
* connection string specifies a password and false otherwise.
311+
* an error. If must_use_password is true, the function raises an error
312+
* if no password is provided in the connection string. In any other case
313+
* it successfully completes.
314314
*/
315315
static void
316316
libpqrcv_check_conninfo(const char *conninfo, bool must_use_password)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.