Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 617fffe

Browse filesBrowse files
Rename removable xid function for consistency.
GlobalVisIsRemovableFullXid() is now GlobalVisCheckRemovableFullXid(). This is consistent with the general convention for FullTransactionId equivalents of functions that deal with TransactionId values. It now matches the nearby GlobalVisCheckRemovableXid() function, which performs the same check for callers that use TransactionId values. Oversight in commit dc7420c. Discussion: https://postgr.es/m/CAH2-Wzmes12jFNDcVgpU89Vp=r6uLFrE-MT0fjSWGsE70UiNaA@mail.gmail.com
1 parent d1d2979 commit 617fffe
Copy full SHA for 617fffe

File tree

Expand file treeCollapse file tree

4 files changed

+4
-4
lines changed
Filter options
Expand file treeCollapse file tree

4 files changed

+4
-4
lines changed

‎src/backend/access/gist/gistutil.c

Copy file name to clipboardExpand all lines: src/backend/access/gist/gistutil.c
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -914,7 +914,7 @@ gistPageRecyclable(Page page)
914914
*/
915915
FullTransactionId deletexid_full = GistPageGetDeleteXid(page);
916916

917-
return GlobalVisIsRemovableFullXid(NULL, deletexid_full);
917+
return GlobalVisCheckRemovableFullXid(NULL, deletexid_full);
918918
}
919919
return false;
920920
}

‎src/backend/access/gist/gistxlog.c

Copy file name to clipboardExpand all lines: src/backend/access/gist/gistxlog.c
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ gistRedoPageReuse(XLogReaderState *record)
388388
* pages in the index via the FSM. That's all they do though.
389389
*
390390
* latestRemovedXid was the page's deleteXid. The
391-
* GlobalVisIsRemovableFullXid(deleteXid) test in gistPageRecyclable()
391+
* GlobalVisCheckRemovableFullXid(deleteXid) test in gistPageRecyclable()
392392
* conceptually mirrors the PGPROC->xmin > limitXmin test in
393393
* GetConflictingVirtualXIDs(). Consequently, one XID value achieves the
394394
* same exclusion effect on primary and standby.

‎src/backend/storage/ipc/procarray.c

Copy file name to clipboardExpand all lines: src/backend/storage/ipc/procarray.c
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4146,7 +4146,7 @@ GlobalVisTestNonRemovableHorizon(GlobalVisState *state)
41464146
* GlobalVisTestIsRemovableFullXid(), see their comments.
41474147
*/
41484148
bool
4149-
GlobalVisIsRemovableFullXid(Relation rel, FullTransactionId fxid)
4149+
GlobalVisCheckRemovableFullXid(Relation rel, FullTransactionId fxid)
41504150
{
41514151
GlobalVisState *state;
41524152

‎src/include/utils/snapmgr.h

Copy file name to clipboardExpand all lines: src/include/utils/snapmgr.h
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ extern bool GlobalVisTestIsRemovableFullXid(GlobalVisState *state, FullTransacti
155155
extern FullTransactionId GlobalVisTestNonRemovableFullHorizon(GlobalVisState *state);
156156
extern TransactionId GlobalVisTestNonRemovableHorizon(GlobalVisState *state);
157157
extern bool GlobalVisCheckRemovableXid(Relation rel, TransactionId xid);
158-
extern bool GlobalVisIsRemovableFullXid(Relation rel, FullTransactionId fxid);
158+
extern bool GlobalVisCheckRemovableFullXid(Relation rel, FullTransactionId fxid);
159159

160160
/*
161161
* Utility functions for implementing visibility routines in table AMs.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.