Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 525a489

Browse filesBrowse files
tglsfdctglsfdc
committed
Remove the last vestige of server-side autocommit.
Long ago we briefly had an "autocommit" GUC that turned server-side autocommit on and off. That behavior was removed in 7.4 after concluding that it broke far too much client-side logic, and making clients cope with both behaviors was impractical. But the GUC variable was left behind, so as not to break any client code that might be trying to read its value. Enough time has now passed that we should remove the GUC completely. Whatever vestigial backwards-compatibility benefit it had is outweighed by the risk of confusion for newbies who assume it ought to do something, as per a recent complaint from Wolfgang Wilhelm. In passing, adjust what seemed to me a rather confusing documentation reference to libpq's autocommit behavior. libpq as such knows nothing about autocommit, so psql is probably what was meant.
1 parent c30be97 commit 525a489
Copy full SHA for 525a489

File tree

Expand file treeCollapse file tree

3 files changed

+2
-27
lines changed
Filter options
Expand file treeCollapse file tree

3 files changed

+2
-27
lines changed

‎doc/src/sgml/ecpg.sgml

Copy file name to clipboardExpand all lines: doc/src/sgml/ecpg.sgml
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,7 @@ EXEC SQL COMMIT;
476476
In the default mode, statements are committed only when
477477
<command>EXEC SQL COMMIT</command> is issued. The embedded SQL
478478
interface also supports autocommit of transactions (similar to
479-
<application>libpq</> behavior) via the <option>-t</option>
479+
<application>psql</>'s default behavior) via the <option>-t</option>
480480
command-line option to <command>ecpg</command> (see <xref
481481
linkend="app-ecpg">) or via the <literal>EXEC SQL SET AUTOCOMMIT TO
482482
ON</literal> statement. In autocommit mode, each command is

‎src/backend/utils/misc/check_guc

Copy file name to clipboardExpand all lines: src/backend/utils/misc/check_guc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
## if an option is valid but shows up in only one file (guc.c but not
1717
## postgresql.conf.sample), it should be listed here so that it
1818
## can be ignored
19-
INTENTIONALLY_NOT_INCLUDED="autocommit debug_deadlocks \
19+
INTENTIONALLY_NOT_INCLUDED="debug_deadlocks \
2020
is_superuser lc_collate lc_ctype lc_messages lc_monetary lc_numeric lc_time \
2121
pre_auth_delay role seed server_encoding server_version server_version_int \
2222
session_authorization trace_lock_oidmin trace_lock_table trace_locks trace_lwlocks \

‎src/backend/utils/misc/guc.c

Copy file name to clipboardExpand all lines: src/backend/utils/misc/guc.c
-25Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,6 @@ static void assign_syslog_facility(int newval, void *extra);
171171
static void assign_syslog_ident(const char *newval, void *extra);
172172
static void assign_session_replication_role(int newval, void *extra);
173173
static bool check_temp_buffers(int *newval, void **extra, GucSource source);
174-
static bool check_phony_autocommit(bool *newval, void **extra, GucSource source);
175174
static bool check_bonjour(bool *newval, void **extra, GucSource source);
176175
static bool check_ssl(bool *newval, void **extra, GucSource source);
177176
static bool check_stage_log_stats(bool *newval, void **extra, GucSource source);
@@ -488,7 +487,6 @@ int huge_pages;
488487
* and is kept in sync by assign_hooks.
489488
*/
490489
static char *syslog_ident_str;
491-
static bool phony_autocommit;
492490
static bool session_auth_is_superuser;
493491
static double phony_random_seed;
494492
static char *client_encoding_string;
@@ -1250,17 +1248,6 @@ static struct config_bool ConfigureNamesBool[] =
12501248
false,
12511249
NULL, NULL, NULL
12521250
},
1253-
{
1254-
/* only here for backwards compatibility */
1255-
{"autocommit", PGC_USERSET, CLIENT_CONN_STATEMENT,
1256-
gettext_noop("This parameter doesn't do anything."),
1257-
gettext_noop("It's just here so that we won't choke on SET AUTOCOMMIT TO ON from 7.3-vintage clients."),
1258-
GUC_NO_SHOW_ALL | GUC_NOT_IN_SAMPLE
1259-
},
1260-
&phony_autocommit,
1261-
true,
1262-
check_phony_autocommit, NULL, NULL
1263-
},
12641251
{
12651252
{"default_transaction_read_only", PGC_USERSET, CLIENT_CONN_STATEMENT,
12661253
gettext_noop("Sets the default read-only status of new transactions."),
@@ -9179,18 +9166,6 @@ check_temp_buffers(int *newval, void **extra, GucSource source)
91799166
return true;
91809167
}
91819168

9182-
static bool
9183-
check_phony_autocommit(bool *newval, void **extra, GucSource source)
9184-
{
9185-
if (!*newval)
9186-
{
9187-
GUC_check_errcode(ERRCODE_FEATURE_NOT_SUPPORTED);
9188-
GUC_check_errmsg("SET AUTOCOMMIT TO OFF is no longer supported");
9189-
return false;
9190-
}
9191-
return true;
9192-
}
9193-
91949169
static bool
91959170
check_bonjour(bool *newval, void **extra, GucSource source)
91969171
{

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.