Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 3cece34

Browse filesBrowse files
committed
Remove special outfuncs/readfuncs handling of RangeVar.catalogname.
Historically we skipped writing/reading this field, but that no longer works under WRITE_READ_PARSE_PLAN_TREES since we expanded the coverage of that option to include utility commands (787102b). Remove the special case and just treat this field normally. Bump catversion out of an abundance of caution --- I do not think we currently ever store RangeVar nodes in the catalogs, but perhaps I'm wrong. Per report from Pavel Stehule. Discussion: https://postgr.es/m/CAFj8pRAYvYu-qU7-NieqRRyaQZk-yr3UjtHQ2LR62PS9M1dZMA@mail.gmail.com
1 parent a9dc7f9 commit 3cece34
Copy full SHA for 3cece34

File tree

2 files changed

+3
-6
lines changed
Filter options

2 files changed

+3
-6
lines changed

‎src/include/catalog/catversion.h

Copy file name to clipboardExpand all lines: src/include/catalog/catversion.h
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,6 @@
5757
*/
5858

5959
/* yyyymmddN */
60-
#define CATALOG_VERSION_NO 202301231
60+
#define CATALOG_VERSION_NO 202301232
6161

6262
#endif

‎src/include/nodes/primnodes.h

Copy file name to clipboardExpand all lines: src/include/nodes/primnodes.h
+2-5Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,11 +64,8 @@ typedef struct RangeVar
6464
{
6565
NodeTag type;
6666

67-
/*
68-
* the catalog (database) name, or NULL; ignored for read/write, since it
69-
* is presently not semantically meaningful
70-
*/
71-
char *catalogname pg_node_attr(read_write_ignore, read_as(NULL));
67+
/* the catalog (database) name, or NULL */
68+
char *catalogname;
7269

7370
/* the schema name, or NULL */
7471
char *schemaname;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.