Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 3146f52

Browse filesBrowse files
tglsfdctglsfdc
committed
Be more careful about port selection in src/test/ldap/.
Don't just assume that the next port is free; it might not be, or if we're really unlucky it might even be out of the TCP range. Do it honestly with two get_free_port() calls instead. This is surely a pretty low-probability problem, but I think it explains a buildfarm failure seen today, so let's fix it. Back-patch to v11 where this script was added. Discussion: https://postgr.es/m/25124.1568052346@sss.pgh.pa.us
1 parent 73ff3a0 commit 3146f52
Copy full SHA for 3146f52

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed

‎src/test/ldap/t/001_auth.pl

Copy file name to clipboardExpand all lines: src/test/ldap/t/001_auth.pl
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
my $ldap_conf = "${TestLib::tmp_check}/ldap.conf";
5757
my $ldap_server = 'localhost';
5858
my $ldap_port = get_free_port();
59-
my $ldaps_port = $ldap_port + 1;
59+
my $ldaps_port = get_free_port();
6060
my $ldap_url = "ldap://$ldap_server:$ldap_port";
6161
my $ldaps_url = "ldaps://$ldap_server:$ldaps_port";
6262
my $ldap_basedn = 'dc=example,dc=net';

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.