Commit 3057465

committed

Replace the sorted array of GUC variables with a hash table.

This gets rid of bsearch() in favor of hashed lookup. The main advantage is that it becomes far cheaper to add new GUCs, since we needn't re-sort the pointer array. Adding N new GUCs had been O(N^2 log N), but now it's closer to O(N). We need to sort only in SHOW ALL and equivalent functions, which are hopefully not performance-critical to anybody. Also, merge GetNumConfigOptions() into get_guc_variables(), because in a world where the set of GUCs isn't fairly static you really want to consider those two results as tied together not independent. Discussion: https://postgr.es/m/2982579.1662416866@sss.pgh.pa.us

1 parent 407b50f commit 3057465Copy full SHA for 3057465

5 files changed

+272

-160

lines changed

src
- backend/utils/misc
- include/utils
  - guc.h
  - guc_tables.h

5 files changed

+272

-160

lines changed

Comments

0 (0)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Commit 3057465

5 files changed

5 files changed

Search code, repositories, users, issues, pull requests...

File tree

5 files changed

5 files changed

0 commit comments