Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 2f30226

Browse filesBrowse files
michaelpqmichaelpq
committed
Fix query checking consistency of table amhandlers in opr_sanity.sql
As written, the query checked for an access method of type 's', which is not an AM type supported in the core code. Error introduced by 8586bf7. As this query is not checking what it should, backpatch all the way down. Reviewed-by: Aleksander Alekseev Discussion: https://postgr.es/m/ZVxJkAJrKbfHETiy@paquier.xyz Backpatch-through: 12
1 parent 3af101c commit 2f30226
Copy full SHA for 2f30226

File tree

Expand file treeCollapse file tree

2 files changed

+2
-2
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+2
-2
lines changed

‎src/test/regress/expected/opr_sanity.out

Copy file name to clipboardExpand all lines: src/test/regress/expected/opr_sanity.out
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1920,7 +1920,7 @@ WHERE p1.oid = a1.amhandler AND a1.amtype = 'i' AND
19201920
-- Check for table amhandler functions with the wrong signature
19211921
SELECT a1.oid, a1.amname, p1.oid, p1.proname
19221922
FROM pg_am AS a1, pg_proc AS p1
1923-
WHERE p1.oid = a1.amhandler AND a1.amtype = 's' AND
1923+
WHERE p1.oid = a1.amhandler AND a1.amtype = 't' AND
19241924
(p1.prorettype != 'table_am_handler'::regtype
19251925
OR p1.proretset
19261926
OR p1.pronargs != 1

‎src/test/regress/sql/opr_sanity.sql

Copy file name to clipboardExpand all lines: src/test/regress/sql/opr_sanity.sql
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1223,7 +1223,7 @@ WHERE p1.oid = a1.amhandler AND a1.amtype = 'i' AND
12231223

12241224
SELECT a1.oid, a1.amname, p1.oid, p1.proname
12251225
FROM pg_am AS a1, pg_proc AS p1
1226-
WHERE p1.oid = a1.amhandler AND a1.amtype = 's' AND
1226+
WHERE p1.oid = a1.amhandler AND a1.amtype = 't' AND
12271227
(p1.prorettype != 'table_am_handler'::regtype
12281228
OR p1.proretset
12291229
OR p1.pronargs != 1

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.