Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 180cf87

Browse filesBrowse files
petergeogheganpetergeoghegan
committed
Remove ineffective heapam CHECK_FOR_INTERRUPTS().
Remove a CHECK_FOR_INTERRUPTS() call that could never actually handle an interrupt. We always have a heap page buffer lock at this point. Having a useless CHECK_FOR_INTERRUPTS() call is harmless but misleading. It is probably possible to work around the immediate problem by moving the CHECK_FOR_INTERRUPTS() to before the heap page buffer lock is acquired. That isn't enough to make the function responsive to interrupts, though. The index AM caller will still hold an exclusive buffer lock of its own.
1 parent 098fb00 commit 180cf87
Copy full SHA for 180cf87

File tree

Expand file treeCollapse file tree

1 file changed

+0
-1
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-1
lines changed

‎src/backend/access/heap/heapam.c

Copy file name to clipboardExpand all lines: src/backend/access/heap/heapam.c
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7086,7 +7086,6 @@ heap_compute_xid_horizon_for_tuples(Relation rel,
70867086
{
70877087
hoffnum = ItemIdGetRedirect(hitemid);
70887088
hitemid = PageGetItemId(hpage, hoffnum);
7089-
CHECK_FOR_INTERRUPTS();
70907089
}
70917090

70927091
/*

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.