postgres
diff --git a/‎src/common/file_utils.c
Copy file name to clipboardExpand all lines: src/common/file_utils.c
+6-8Lines changed: 6 additions & 8 deletions b/‎src/common/file_utils.c
Copy file name to clipboardExpand all lines: src/common/file_utils.c
+6-8Lines changed: 6 additions & 8 deletions
@@ -51,8 +51,6 @@ static void walkdir(const char *path,
  * fsyncing, and might not have privileges to write at all.
  *
  * serverVersion indicates the version of the server to be fsync'd.
- *
- * Errors are reported but not considered fatal.
  */
 void
 fsync_pgdata(const char *pg_data,
@@ -250,8 +248,8 @@ pre_sync_fname(const char *fname, bool isdir)
  * fsync_fname -- Try to fsync a file or directory
  *
  * Ignores errors trying to open unreadable files, or trying to fsync
- * directories on systems where that isn't allowed/required.  Reports
- * other errors non-fatally.
+ * directories on systems where that isn't allowed/required.  All other errors
+ * are fatal.
  */
 int
 fsync_fname(const char *fname, bool isdir)
@@ -294,9 +292,9 @@ fsync_fname(const char *fname, bool isdir)
 	 */
 	if (returncode != 0 && !(isdir && (errno == EBADF || errno == EINVAL)))
 	{
-		pg_log_error("could not fsync file \"%s\": %m", fname);
+		pg_log_fatal("could not fsync file \"%s\": %m", fname);
 		(void) close(fd);
-		return -1;
+		exit(EXIT_FAILURE);
 	}
 
 	(void) close(fd);
@@ -364,9 +362,9 @@ durable_rename(const char *oldfile, const char *newfile)
 	{
 		if (fsync(fd) != 0)
 		{
-			pg_log_error("could not fsync file \"%s\": %m", newfile);
+			pg_log_fatal("could not fsync file \"%s\": %m", newfile);
 			close(fd);
-			return -1;
+			exit(EXIT_FAILURE);
 		}
 		close(fd);
 	}
Original file line number	Diff line number	Diff line change
`@@ -51,8 +51,6 @@ static void walkdir(const char *path,`
`51`	`51`	`* fsyncing, and might not have privileges to write at all.`
`52`	`52`	`*`
`53`	`53`	`* serverVersion indicates the version of the server to be fsync'd.`
`54`		`- *`
`55`		`- * Errors are reported but not considered fatal.`
`56`	`54`	`*/`
`57`	`55`	`void`
`58`	`56`	`fsync_pgdata(const char *pg_data,`
`@@ -250,8 +248,8 @@ pre_sync_fname(const char *fname, bool isdir)`
`250`	`248`	`* fsync_fname -- Try to fsync a file or directory`
`251`	`249`	`*`
`252`	`250`	`* Ignores errors trying to open unreadable files, or trying to fsync`
`253`		`- * directories on systems where that isn't allowed/required. Reports`
`254`		`- * other errors non-fatally.`
	`251`	`+ * directories on systems where that isn't allowed/required. All other errors`
	`252`	`+ * are fatal.`
`255`	`253`	`*/`
`256`	`254`	`int`
`257`	`255`	`fsync_fname(const char *fname, bool isdir)`
`@@ -294,9 +292,9 @@ fsync_fname(const char *fname, bool isdir)`
`294`	`292`	`*/`
`295`	`293`	`if (returncode != 0 && !(isdir && (errno == EBADF \|\| errno == EINVAL)))`
`296`	`294`	`{`
`297`		`- pg_log_error("could not fsync file \"%s\": %m", fname);`
	`295`	`+ pg_log_fatal("could not fsync file \"%s\": %m", fname);`
`298`	`296`	`(void) close(fd);`
`299`		`- return -1;`
	`297`	`+ exit(EXIT_FAILURE);`
`300`	`298`	`}`
`301`	`299`
`302`	`300`	`(void) close(fd);`
`@@ -364,9 +362,9 @@ durable_rename(const char oldfile, const char newfile)`
`364`	`362`	`{`
`365`	`363`	`if (fsync(fd) != 0)`
`366`	`364`	`{`
`367`		`- pg_log_error("could not fsync file \"%s\": %m", newfile);`
	`365`	`+ pg_log_fatal("could not fsync file \"%s\": %m", newfile);`
`368`	`366`	`close(fd);`
`369`		`- return -1;`
	`367`	`+ exit(EXIT_FAILURE);`
`370`	`368`	`}`
`371`	`369`	`close(fd);`
`372`	`370`	`}`