Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 13a6fa3

Browse filesBrowse files
committed
pg_upgrade: Add C comment about NextXID delimiter
We don't test the catversion for the NextXID delimiter change, we just test the string contents; explain why. Reported-by: Michael Paquier
1 parent 59a884e commit 13a6fa3
Copy full SHA for 13a6fa3

File tree

Expand file treeCollapse file tree

1 file changed

+6
-1
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+6
-1
lines changed

‎src/bin/pg_upgrade/controldata.c

Copy file name to clipboardExpand all lines: src/bin/pg_upgrade/controldata.c
+6-1Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,9 +197,14 @@ get_control_data(ClusterInfo *cluster, bool live_check)
197197
p++; /* remove ':' char */
198198
cluster->controldata.chkpnt_nxtepoch = str2uint(p);
199199

200+
/*
201+
* Delimiter changed from '/' to ':' in 9.6. We don't test for
202+
* the catalog version of the change because the catalog version
203+
* is pulled from pg_controldata too, and it isn't worth adding
204+
* an order dependency for this --- we just check the string.
205+
*/
200206
if (strchr(p, '/') != NULL)
201207
p = strchr(p, '/');
202-
/* delimiter changed from '/' to ':' in 9.6 */
203208
else if (GET_MAJOR_VERSION(cluster->major_version) >= 906)
204209
p = strchr(p, ':');
205210
else

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.