Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 10a5992

Browse filesBrowse files
committed
Fix comment about ressortgrouprefs being unique in setop plans.
Author: Richard Guo, Tom Lane Discussion: https://www.postgresql.org/message-id/CAMbWs49rAfFS-yd7=QxtDUrZDFfRBGy4rGBJNyGDH7=CLipFPg@mail.gmail.com
1 parent f36b636 commit 10a5992
Copy full SHA for 10a5992

File tree

Expand file treeCollapse file tree

1 file changed

+8
-1
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+8
-1
lines changed

‎src/backend/optimizer/plan/setrefs.c

Copy file name to clipboardExpand all lines: src/backend/optimizer/plan/setrefs.c
+8-1Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2936,7 +2936,14 @@ search_indexed_tlist_for_sortgroupref(Expr *node,
29362936
{
29372937
TargetEntry *tle = (TargetEntry *) lfirst(lc);
29382938

2939-
/* The equal() check should be redundant, but let's be paranoid */
2939+
/*
2940+
* Usually the equal() check is redundant, but in setop plans it may
2941+
* not be, since prepunion.c assigns ressortgroupref equal to the
2942+
* column resno without regard to whether that matches the topmost
2943+
* level's sortgrouprefs and without regard to whether any implicit
2944+
* coercions are added in the setop tree. We might have to clean that
2945+
* up someday; but for now, just ignore any false matches.
2946+
*/
29402947
if (tle->ressortgroupref == sortgroupref &&
29412948
equal(node, tle->expr))
29422949
{

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.