Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 1046dbe

Browse filesBrowse files
committed
Silence another gcc 11 warning.
Per buildfarm and local experimentation, bleeding-edge gcc isn't convinced that the MemSet in reorder_function_arguments() is safe. Shut it up by adding an explicit check that pronargs isn't negative, and by changing MemSet to memset. (It appears that either change is enough to quiet the warning at -O2, but let's do both to be sure.)
1 parent 6f5c8a8 commit 1046dbe
Copy full SHA for 1046dbe

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed

‎src/backend/optimizer/util/clauses.c

Copy file name to clipboardExpand all lines: src/backend/optimizer/util/clauses.c
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3805,9 +3805,9 @@ reorder_function_arguments(List *args, HeapTuple func_tuple)
38053805
int i;
38063806

38073807
Assert(nargsprovided <= pronargs);
3808-
if (pronargs > FUNC_MAX_ARGS)
3808+
if (pronargs < 0 || pronargs > FUNC_MAX_ARGS)
38093809
elog(ERROR, "too many function arguments");
3810-
MemSet(argarray, 0, pronargs * sizeof(Node *));
3810+
memset(argarray, 0, pronargs * sizeof(Node *));
38113811

38123812
/* Deconstruct the argument list into an array indexed by argnumber */
38133813
i = 0;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.