Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 039dc49

Browse filesBrowse files
committed
Remove Assert(BgWriterShmem != NULL), which is rather pointless since
we'd dump core anyway immediately afterward if it were null; and it seems to confuse some versions of icc into generating bad code. Per report from Sergey Koposov. Patched in HEAD only, for the moment, since this is only likely to affect developers.
1 parent 22d98e7 commit 039dc49
Copy full SHA for 039dc49

File tree

Expand file treeCollapse file tree

1 file changed

+1
-3
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-3
lines changed

‎src/backend/postmaster/bgwriter.c

Copy file name to clipboardExpand all lines: src/backend/postmaster/bgwriter.c
+1-3Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
*
3838
*
3939
* IDENTIFICATION
40-
* $PostgreSQL: pgsql/src/backend/postmaster/bgwriter.c,v 1.42 2007/09/11 17:15:33 tgl Exp $
40+
* $PostgreSQL: pgsql/src/backend/postmaster/bgwriter.c,v 1.43 2007/09/16 16:33:04 tgl Exp $
4141
*
4242
*-------------------------------------------------------------------------
4343
*/
@@ -189,7 +189,6 @@ BackgroundWriterMain(void)
189189
sigjmp_buf local_sigjmp_buf;
190190
MemoryContext bgwriter_context;
191191

192-
Assert(BgWriterShmem != NULL);
193192
BgWriterShmem->bgwriter_pid = MyProcPid;
194193
am_bg_writer = true;
195194

@@ -987,7 +986,6 @@ ForwardFsyncRequest(RelFileNode rnode, BlockNumber segno)
987986

988987
if (!IsUnderPostmaster)
989988
return false; /* probably shouldn't even get here */
990-
Assert(BgWriterShmem != NULL);
991989

992990
LWLockAcquire(BgWriterCommLock, LW_EXCLUSIVE);
993991
if (BgWriterShmem->bgwriter_pid == 0 ||

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.