Exclude sys.pycache_prefix from search for jep in python startup script#1455
Merged
jeremyrsmith merged 1 commit intopolynote:masterpolynote/polynote:masterfrom Nov 21, 2024
JanukanS:remove-pycache-prefixJanukanS/polynote:remove-pycache-prefixCopy head branch name to clipboard
Merged
Exclude sys.pycache_prefix from search for jep in python startup script#1455jeremyrsmith merged 1 commit intopolynote:masterpolynote/polynote:masterfrom JanukanS:remove-pycache-prefixJanukanS/polynote:remove-pycache-prefixCopy head branch name to clipboard
jeremyrsmith merged 1 commit intopolynote:masterpolynote/polynote:masterfrom
JanukanS:remove-pycache-prefixJanukanS/polynote:remove-pycache-prefixCopy head branch name to clipboard
Conversation
Contributor
|
Thanks @JanukanS! I have seen this issue locally too... I think I hacked around it just by filtering all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously running the polynote.py startup script gave me the following error (WSL2, Ubuntu 22.04.1 LTS, Python 3.12.3)
Traceback (most recent call last): File "/home/janukan/projects/polynote/scripts/polynote.py", line 13, in <module> os.environ['PYTHONPATH'] = os.pathsep.join(sys_prefixes) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ TypeError: sequence item 0: expected str instance, NoneType foundThis error is caused by sys_prefixes including the value for sys.pycache_prefix. When sys.pycache_prefix is not set by a command-line option or an environment variable, it defaults to None. As sys.pycache_prefix determines where bytecode files are stored, it seems safe to exclude this from the search for jep.