Bincompat for ByteBuffer#rewind#1451
Closed
jeremyrsmith wants to merge 1 commit intomasterpolynote/polynote:masterfrom
Closed
Bincompat for ByteBuffer#rewind#1451jeremyrsmith wants to merge 1 commit intomasterpolynote/polynote:masterfrom
jeremyrsmith wants to merge 1 commit intomasterpolynote/polynote:masterfrom
Conversation
JDK17 introduces a new overload of this method. When you build on JDK17, it selects that version which makes in binary incompatible with JDK8. This fixes it by only using `rewind` from the parent class `Buffer`.
anthonyjpratti
approved these changes
Oct 24, 2024
Contributor
Author
|
I think we'll prefer #1452, assuming it works correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JDK17 introduces a new overload of this method. When you build on JDK17, it selects that version which makes in binary incompatible with JDK8.
This fixes it by only using
rewindfrom the parent classBuffer.