Drop Scala 2.11, update circe#1448
Merged
jeremyrsmith merged 9 commits intomasterpolynote/polynote:masterfrom Oct 23, 2024
Merged
Drop Scala 2.11, update circe#1448jeremyrsmith merged 9 commits intomasterpolynote/polynote:masterfrom
jeremyrsmith merged 9 commits intomasterpolynote/polynote:masterfrom
Conversation
|
|
||
| val distBuildDir = file(".") / "target" / "dist" / "polynote" | ||
| val scalaVersions = Seq("2.11.12", "2.12.15", "2.13.6") | ||
| val scalaVersions = Seq("2.12.15", "2.13.6") |
Collaborator
There was a problem hiding this comment.
Any reason not to bump to the latest 2.12.x and 2.13.x while we're here?
| val sparkVersions = Map( | ||
| "2.11" -> "2.1.1", | ||
| "2.12" -> "3.1.2", | ||
| "2.13" -> "3.2.1" |
Collaborator
There was a problem hiding this comment.
Probably for a separate PR, but we should probably update the Spark versions too
| |---------------------------------|-------------------------------------------------------| | ||
| | Base image with Scala 2.12 | `polynote/polynote:${POLYNOTE_VERSION}-2.12` | | ||
| | Base image with Scala 2.13 | `polynote/polynote:${POLYNOTE_VERSION}-2.12` | | ||
| | Spark 2.4 image with Scala 2.12 | `polynote/polynote:${POLYNOTE_VERSION}-2.12-spark2.4` | |
Collaborator
There was a problem hiding this comment.
Should we drop Spark 2.4 from this list?
Collaborator
|
I think we need to update polynote/.github/workflows/dist.yml Line 39 in 2d6f1ba We can also remove some other 2.11 logic e.g., in (and probably the 2.4 support too?) |
| implicit val circeConfig: Configuration = | ||
| Configuration.default.withSnakeCaseConstructorNames.withSnakeCaseMemberNames.withDefaults | ||
|
|
||
| abstract class ValidatedConfigDecoder[A] extends ConfiguredDecoder[A](circeConfig.copy(useDefaults = false)) |
| docker build --build-arg POLYNOTE_VERSION --build-arg SCALA_VERSION -t polynote/polynote:${POLYNOTE_VERSION}-${SCALA_VERSION}-spark2.4 docker/spark | ||
| docker push polynote/polynote:${POLYNOTE_VERSION}-${SCALA_VERSION}-spark2.4 | ||
| docker tag polynote/polynote:${POLYNOTE_VERSION}-${SCALA_VERSION}-spark2.4 polynote/polynote:latest | ||
| docker push polynote/polynote:latest |
Collaborator
There was a problem hiding this comment.
@jeremyrsmith Updated dist.yml like we discussed. I think this is the only change necessary? I guess we will find out one way or another once this is merged...
jonathanindig
approved these changes
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.