expose add font family method#2
Merged
polybioz merged 1 commit intopolybioz:masterpolybioz/HTML-Renderer-Core:masterfrom Jan 5, 2025
Shayaomer:feature/expose-add-font-familyShayaomer/HTML-Renderer-Core:feature/expose-add-font-familyCopy head branch name to clipboard
Merged
expose add font family method#2polybioz merged 1 commit intopolybioz:masterpolybioz/HTML-Renderer-Core:masterfrom Shayaomer:feature/expose-add-font-familyShayaomer/HTML-Renderer-Core:feature/expose-add-font-familyCopy head branch name to clipboard
polybioz merged 1 commit intopolybioz:masterpolybioz/HTML-Renderer-Core:masterfrom
Shayaomer:feature/expose-add-font-familyShayaomer/HTML-Renderer-Core:feature/expose-add-font-familyCopy head branch name to clipboard
Conversation
In order to add custom font that loaded locally in the project, it's essential to insert the font name into the exisiting fonts dictionary. thus I exposed the insert method to the PdfGenerator class
Author
|
@polybioz Hey, mind approving this ? |
polybioz
approved these changes
Jan 5, 2025
Author
|
@polybioz thanks for the quick approval, can you please republish this nuget with the changes so I can use it as nuget? |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to add custom font that loaded locally in my project, it's essential to insert the font name into the exisiting fonts dictionary.
Thus I exposed the AddFontFamily method to the PdfGenerator class, in order to add my custom fonts to the _exisitingFont dicitonary and use those fonts instead of the default Segoe UI.
I havn't found another way to use custom fonts on non-windows machines.