💖 Thanks for opening this pull request! 💖
Please be patient and we will get back to you as soon as we can.

The hint only makes sense if there is such script in package.json, which can be checked.

It's a hint, so I don't think it matters whether it's factually correct. It's up to the user to decide the relevance. Besides, the situation where it's irrelevant is far less likely. Most users run pnpm deploy outside workspace because they have a script by that name.

Also, if we're going to fact-check the hint, then we might as well actually run the script when pnpm deploy (without run) is invoked outside workspace. This is what #9475 wants (rather than a fact-checked hint). Do you agree to have it implemented this way instead? @zkochan

You are making a big deal from it although it isn't a big change. I'll push it.

I don't think it is a good idea to allow it outside a workspace. What if we will implement it for single-package workspace?

@zkochan Thank you for doing the change, and I apologize for the emotions.

Hope this can be merged in to help reduce confusion in future pnpm versions. Thanks! :)

PS: The test failure in Windows doesn't look related, though I'm not sure:

  FAIL test/dlx.ts (196.57 s)
    ● dlx creates cache and store prune cleans cache
  
      Command timed out after 180000ms
  
        163 | function registerProcessTimeout (proc: NodeChildProcess, timeout: number, onTimeout: (reason: Error) => void) {
        164 |   return setTimeout(() => {
      > 165 |     onTimeout(new Error(`Command timed out after ${timeout}ms`))
            |               ^
  
        at Timeout._onTimeout (test/utils/execPnpm.ts:165:15)

Congrats on merging your first pull request! 🎉🎉🎉