Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@btea
Copy link
Member

@btea btea commented Aug 29, 2025

refer to #8889 (comment)

image

@btea btea requested a review from zkochan as a code owner August 29, 2025 06:41
@zkochan
Copy link
Member

zkochan commented Aug 29, 2025

That's good but what they also want is to show whether previous versions (or the current one?) had attestation.

@btea
Copy link
Member Author

btea commented Aug 29, 2025

Maybe split Provenance into two columns? CurrentProvenance and TargetProvenance?

@zkochan
Copy link
Member

zkochan commented Aug 29, 2025

no, I think one column is enough. But if it was downgraded, just print something like "danger, provenance removed"

@btea
Copy link
Member Author

btea commented Aug 29, 2025

no, I think one column is enough. But if it was downgraded, just print something like "danger, provenance removed"

Whether this print information should be used when installing dependencies is determined.

@SuperchupuDev
Copy link
Contributor

as a suggestion, it'd be nice if it could show different values based on provenance coming from trusted publishing or not, like this: https://github.com/antfu-collective/taze/blob/54aeef30400423db32e7adda950ea3ecc2a9fe86/src/commands/check/render.ts#L68-L70

@tats-u
Copy link

tats-u commented Sep 4, 2025

Current \ Newer Trusted Untrusted None
Trusted Unchanged (Green) Untrusted (Red) Removed (Red)
Untrusted Trusted (Green) Unchanged (Green) Removed (Red)
None Trusted (Green) Untrusted (Green) None (Gray)

@btea
Copy link
Member Author

btea commented Sep 4, 2025

const ABBREVIATED_DOC = 'application/vnd.npm.install-v1+json; q=1.0, application/json; q=0.8, */*'

To reduce the request content, a special request header is added, so the return content does not contain _npmUser.trustedPublisher related information.

@sxzz
Copy link

sxzz commented Sep 4, 2025

Yes, taze uses Anthony's proxy service, npm.antfu.dev, by default. This allows us to receive an incredibly small response size while still including the necessary provenance information. However, this does not apply to pnpm; we need to request that the npm registry add this field.

@btea btea changed the title feat: update choice list show the provenance column feat: add checkProvenance config Sep 12, 2025
@btea btea marked this pull request as draft September 12, 2025 01:55
@btea btea marked this pull request as ready for review September 13, 2025 08:22
@btea btea marked this pull request as draft November 10, 2025 01:43
@btea btea changed the title feat: add checkProvenance config feat: update choice list show the provence column Nov 10, 2025
@btea btea marked this pull request as ready for review November 11, 2025 05:43
@btea
Copy link
Member Author

btea commented Nov 18, 2025

What do you think of the current solution? Should the provenance column only be displayed when trustPolicy is set to no-downgrade, or should this column be displayed by default? @zkochan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.