feat: add npm version management for publish command #10092
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkochan
requested changes
Oct 22, 2025
Member
zkochan
left a comment
There was a problem hiding this comment.
We probably need to use the devEngines.packageManager field for this. But then pnpm will fail to run because it will tell that another package manager should be used... We could probably have an array of package managers. So, both pnpm and npm.
Member
Author
|
Sounds good, that approach should also fix #9924. |
louis-bompart
added a commit
to coveo/ui-kit
that referenced
this pull request
Oct 29, 2025
alleviates pnpm/pnpm#10092
| } | ||
|
|
||
| manifest[dependenciesFieldName] ??= {} | ||
| manifest[dependenciesFieldName]![packageManagerName] = `packageManager:${versionToUse}` |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9812 (comment)
Added support for specifying npm version in
pnpm-workspace.yamlto enable features like OIDC publishing that require specific npm versions.When running pnpm publish, the specified npm version is automatically downloaded, cached to
$PNPM_HOME/.tools/npm/{version}/, and used for publishing.