USA Choropleths OSError fixed in Windows #980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriddyp
reviewed
Mar 26, 2018
CHANGELOG.md
Outdated
|
|
||
| ## [2.5.1] - 2018-03-26 | ||
| ### Fixed | ||
| - `plotly.figure_factory.create_choropleth` now works in Windows without raising an OSError. The module now uses intelligent path tools from `os` to manipulate and manage the shapefiles packaged with Plotly |
Member
There was a problem hiding this comment.
instead of "intelligent", maybe "cross-platform"?
Member
There was a problem hiding this comment.
manage the shapefiles packaged with Plotly
"manage the shapefiles contained in this package."
Member
|
💃 once tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the issue: https://community.plot.ly/t/us-county-choropleth-map/8629
cc. @cldougl @chriddyp ready for review
I've updated the CHANGELOG and bumped version number in this PR as I think it's best to push this to pip asap