Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix for 1.9.8 offline plotting issue #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 16, 2016
Merged

Fix for 1.9.8 offline plotting issue #440

merged 5 commits into from
Apr 16, 2016

Conversation

yankev
Copy link
Contributor

@yankev yankev commented Apr 15, 2016

@@ -121,17 +121,27 @@ def _plot_html(figure_or_data, show_link, link_text,
layout=jlayout,
config=jconfig)

if kwargs and kwargs['browser']:
Copy link
Member

@chriddyp chriddyp Apr 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of **kwargs and "browser" maybe something more explicit, like "global_requirejs"

@cldougl
Copy link
Member

cldougl commented Apr 16, 2016

+1 for using global_requirejs over **kwargs thanks for changing that @yankev
💃 (when the tests ✔️ )

@yankev yankev merged commit d88c5d0 into master Apr 16, 2016
@cldougl cldougl deleted the offline_plot branch March 24, 2017 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.