Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

🐛 get the correct plotly_domain, not the "session"'s #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 1, 2015

Conversation

chriddyp
Copy link
Member

@chriddyp chriddyp commented Dec 1, 2015

No description provided.

@chriddyp
Copy link
Member Author

chriddyp commented Dec 1, 2015

cc @theengineear , @etpinard , @cldougl

plotly_platform_url = session.get_session_config().get('plotly_domain',
'https://plot.ly')
# TODO: The get_config 'source of truth' should
# really be somewhere other than plotly.plotly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind tagging this with an issue in this repo? 🐹

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theengineear
Copy link
Contributor

Loving the commit emojis :)

Non-blocking --> 💃

chriddyp added a commit that referenced this pull request Dec 1, 2015
🐛 get the correct plotly_domain, not the "session"'s
@chriddyp chriddyp merged commit 20102d6 into master Dec 1, 2015
@chriddyp chriddyp deleted the fix-offline-enterprise-url branch December 1, 2015 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.