plot method in GraphWidget
#192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "`dict`-like or `list`-like.") | ||
| if validate_figure: | ||
| try: | ||
| validate(figure, obj_type='Figure') |
There was a problem hiding this comment.
that darn tools.validate. if that didn't exist, i woulda placed this function in utils.py since i can't imagine anyone actually needing it.
| ### Changelog | ||
|
|
||
| - 1.6.7 | ||
| Added `plot` method to `plotly.widgets.GraphWidget` for easy-to-use client-side graphing |
There was a problem hiding this comment.
Any reasons for not using GitHub releases instead ?
|
👍 |
|
yeah, you're right, releases looks a bit nicer (e.g. https://github.com/ipython/ipython/releases) |
| @@ -247,6 +246,18 @@ def message_handler(widget, ranges): | ||
| """ | ||
| self._handle_registration('zoom', callback, remove) | ||
|
|
||
| def plot(self, figure_or_data, validate=True): | ||
| """Plot figure_or_data in the Plotly graph. | ||
| """ |
There was a problem hiding this comment.
Mind throwing in a couple extra lines for docs describing the args?
|
looking good, just a couple notes in there from me |
chriddyp
added a commit
that referenced
this pull request
Feb 20, 2015
`plot` method in `GraphWidget`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage: http://nbviewer.ipython.org/gist/chriddyp/e8c21827120220791684
@theengineear