Fix plotly express marginals

Go back to start_cell bottom-left since that makes marginal code easier. Now flip the row index of traces before they are inserted in the grid.
plotly · jonmmease · Aug 7, 2019 · Aug 4, 2019 · Aug 4, 2019 · Aug 4, 2019
commit 589460cb11b7e6647a8ab8d0669d37c1398d00f9
diff --git a/packages/python/plotly/plotly/express/_core.py b/packages/python/plotly/plotly/express/_core.py
@@ -352,12 +352,18 @@ def configure_cartesian_marginal_axes(args, fig, orders):

    # Add axis titles to non-marginal subplots
    y_title = get_decorated_label(args, args["y"], "y")
-    for row in range(1, nrows):
-        fig.update_yaxes(title_text=y_title, row=row, col=1)
+    if args["marginal_x"]:
+        fig.update_yaxes(title_text=y_title, row=1, col=1)
+    else:
+        for row in range(1, nrows + 1):
+            fig.update_yaxes(title_text=y_title, row=row, col=1)

    x_title = get_decorated_label(args, args["x"], "x")
-    for col in range(1, ncols):
-        fig.update_xaxes(title_text=x_title, row=1, col=col)
+    if args["marginal_y"]:
+        fig.update_xaxes(title_text=x_title, row=1, col=1)
+    else:
+        for col in range(1, ncols + 1):
+            fig.update_xaxes(title_text=x_title, row=1, col=col)

    # Configure axis type across all x-axes
    if "log_x" in args and args["log_x"]:
@@ -393,8 +399,7 @@ def configure_cartesian_axes(args, fig, orders):

    # Set x-axis titles and axis options in the bottom-most row
    x_title = get_decorated_label(args, args["x"], "x")
-    nrows = len(fig._grid_ref)
-    for xaxis in fig.select_xaxes(row=nrows):
+    for xaxis in fig.select_xaxes(row=1):
        xaxis.update(title_text=x_title)
        set_cartesian_axis_opts(args, xaxis, "x", orders)

@@ -959,7 +964,7 @@ def make_figure(args, constructor, trace_patch={}, layout_patch={}):
                    row = m.val_map[val]
                    trace._subplot_row_val = val
                else:
-                    if trace_spec.marginal == "x":
+                    if has_marginal_x and trace_spec.marginal != "x":
                        row = 2
                    else:
                        row = 1
@@ -1040,7 +1045,11 @@ def make_figure(args, constructor, trace_patch={}, layout_patch={}):
                continue

            _set_trace_grid_reference(
-                trace, fig.layout, fig._grid_ref, trace._subplot_row, trace._subplot_col
+                trace,
+                fig.layout,
+                fig._grid_ref,
+                nrows - trace._subplot_row + 1,
+                trace._subplot_col,
            )

    # Add traces, layout and frames to figure
@@ -1123,13 +1132,13 @@ def init_figure(
        specs=specs,
        shared_xaxes="all",
        shared_yaxes="all",
-        row_titles=row_titles,
+        row_titles=list(reversed(row_titles)),
        column_titles=column_titles,
        horizontal_spacing=horizontal_spacing,
        vertical_spacing=vertical_spacing,
        row_heights=row_heights,
        column_widths=column_widths,
-        start_cell="top-left",
+        start_cell="bottom-left",
    )

    # Remove explicit font size of row/col titles so template can take over