Remove HTML entity decoding from convertToSVG #804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unnecessary and imposes a performance hit on long strings.
|
This breaks some existing behaviour. Will investigate. |
|
It turns out we depended on entity decoding in parts of plotly.js itself, and in one mock plot, but those were easy to fix. Also some of the XSS tests needed to be modified. I have manually verified that we did not break any existing XSS protection. |
|
Looks good 💃 Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove HTML entity decoding from convertToSVG - this is unnecessary and imposes a performance hit on long strings.