Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

make offsetgroup work with barmode 'stacked' and 'relative' for bar traces #7247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 23 commits into from
Closed

make offsetgroup work with barmode 'stacked' and 'relative' for bar traces #7247

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
a3fbabf
For bar traces make offsetgroup work with barmode 'stacked' and 'rela…
my-tien Jun 1, 2024
16cb035
Fix handleGroupingDefaults calls outside of bar/defaults.js
my-tien Jun 3, 2024
3f3a30e
Fix linter error on missing newline at EOF
my-tien Jun 3, 2024
bdce78a
Fix offset calculation and stacking for barpolar
my-tien Jun 4, 2024
c0d3216
Fix angularaxis check in setOffsetAndWidth
my-tien Jun 5, 2024
9ae2c10
consider modes of other traces as well (scattermode, funnelmode,... )
my-tien Jun 5, 2024
eb101ff
Don't use poffset for sieve.put, use trace._offsetIndex instead.
my-tien Jun 5, 2024
641a544
Fix logic for adding a gap between bars
my-tien Jun 5, 2024
8f020f6
baseline image for zzz_bar_relative_offsetgroup
my-tien Jun 5, 2024
a4fde80
Fix sieve for offsetgroups
my-tien Jun 6, 2024
48c469e
Fix for failing baseline test waterfall_funnel_template_date
my-tien Jun 6, 2024
31bb43a
Pass missing barmode param for histogram
my-tien Jun 6, 2024
81450bd
Ensure offsetIndex and offsetgroup are not undefined
my-tien Jun 6, 2024
3817206
Track alignmentgroups in fullLayout._alignmentOpts by trace type
my-tien Jun 7, 2024
3ec003d
Make offsetgroup work for boxmode overlay as well
my-tien Jun 7, 2024
3830b94
Documentation for setOffsetAndWidth and fix for sieve documentations
my-tien Jun 7, 2024
5faf455
Revert "Make offsetgroup work for boxmode overlay as well"
my-tien Aug 28, 2024
ea23867
Revert "Track alignmentgroups in fullLayout._alignmentOpts by trace t…
my-tien Aug 28, 2024
28b81a1
Ignore offsetgroup and alignmentgroup for those trace types that don'…
my-tien Aug 28, 2024
9601710
Update funnel test after adding support for alignmentgroup and offset…
my-tien Sep 2, 2024
e6445ba
Update bar test after adding support for alignmentgroup and offsetgro…
my-tien Sep 2, 2024
d291aad
Update baseline images for legendgroup_bar-stack and funnel_attrs
my-tien Sep 4, 2024
3ce0778
Adds draftlog.
stephprobst Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update bar test after adding support for alignmentgroup and offsetgro… 
…up for stackable traces
  • Loading branch information
@my-tien @stephprobst
my-tien authored and stephprobst committed Oct 22, 2024
commit e6445baf55703e9cb341163bf0755da2478a4515
6 changes: 3 additions & 3 deletions 6 test/jasmine/tests/bar_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ describe('Bar.supplyDefaults', function() {
expect(traceOut.ycalendar).toBe('ethiopian');
});

it('should not include alignmentgroup/offsetgroup when barmode is not *group*', function() {
it('should include alignmentgroup/offsetgroup regardless of barmode', function() {
var gd = {
data: [{type: 'bar', y: [1], alignmentgroup: 'a', offsetgroup: '1'}],
layout: {barmode: 'group'}
Expand All @@ -255,8 +255,8 @@ describe('Bar.supplyDefaults', function() {

gd.layout.barmode = 'stack';
supplyAllDefaults(gd);
expect(gd._fullData[0].alignmentgroup).toBe(undefined, 'alignementgroup');
expect(gd._fullData[0].offsetgroup).toBe(undefined, 'offsetgroup');
expect(gd._fullData[0].alignmentgroup).toBe('a', 'alignementgroup');
expect(gd._fullData[0].offsetgroup).toBe('1', 'offsetgroup');
});

it('should have a barmode only if it contains bars', function() {
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.