Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Use URLs directly for layout images #7199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Use URLs directly for layout images #7199

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf57b39
use url directly for layout images when not in static mode
alexcjohnson Oct 2, 2024
9892ac7
Merge branch 'release-v2.35.3' into alex/direct-images
alexcjohnson Oct 7, 2024
b1fd955
adapt layout images tests to new direct-unless-staticPlot behavior
alexcjohnson Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
use url directly for layout images when not in static mode 
The data uri is necessary for export only, which should always use staticPlot
  • Loading branch information
@alexcjohnson
alexcjohnson committed Oct 2, 2024
commit cf57b3966d4dfceed6a4ccf6265d6332d6bff97a
2 changes: 1 addition & 1 deletion 2 src/components/images/draw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ module.exports = function draw(gd) {

thisImage.attr('xmlns', xmlnsNamespaces.svg);

if(d.source && d.source.slice(0, 5) === 'data:') {
if(!gd._context.staticPlot || (d.source && d.source.slice(0, 5) === 'data:')) {
thisImage.attr('xlink:href', d.source);
this._imgSrc = d.source;
} else {
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.