Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix resizing pie like traces when textinfo is set to "none" #6893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Fix resizing pie like traces when textinfo is set to "none" #6893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96e1c51
coerce textposition if textinfo is "none"
robbtraister Feb 12, 2024
e8517a7
add draft log
robbtraister Feb 12, 2024
3a9aa1b
fix linting
robbtraister Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions 1 draftlogs/6893_fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fix possible NPE when `textinfo: "none"` for pie and funnelarea traces
2 changes: 2 additions & 0 deletions 2 src/traces/funnelarea/defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
moduleHasTextangle: false,
moduleHasInsideanchor: false
});
} else if(textInfo === 'none') {
coerce('textposition', 'none');
}

handleDomainDefaults(traceOut, layout, coerce);
Expand Down
2 changes: 2 additions & 0 deletions 2 src/traces/pie/defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@ function supplyDefaults(traceIn, traceOut, defaultColor, layout) {
if(textposition === 'inside' || textposition === 'auto' || Array.isArray(textposition)) {
coerce('insidetextorientation');
}
} else if(textInfo === 'none') {
coerce('textposition', 'none');
}

handleDomainDefaults(traceOut, layout, coerce);
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.