Use Lib.psuedoRandom(), not Math.random()

plotly · archmoj · Jan 4, 2024 · Dec 27, 2023 · Jan 2, 2024 · Jan 2, 2024
commit 365231d4c81dd970f563e49afbcc8be191809822
diff --git a/test/jasmine/tests/axes_test.js b/test/jasmine/tests/axes_test.js
@@ -8229,7 +8229,8 @@ fdescribe('test tickmode calculator', function() {
      standardConfig = {tickmode: 'array', ticks: 'inside', ticklen: 1, showticklabels: false};

      // Number of ticks will be random
-      var n = Math.floor(Math.random() * 99) + 1;
+      Lib.seedPseudoRandom();
+      var n = (Lib.pseudoRandom() * 99) + 1;
      tickVals = [];
      for(let i = 0; i <= n; i++) {
        tickVals.push(i);
-Original file line number
+Diff line change
@@ -8229,7 +8229,8 @@ fdescribe('test tickmode calculator', function() {
           standardConfig = {tickmode: 'array', ticks: 'inside', ticklen: 1, showticklabels: false};
           // Number of ticks will be random
             Copy link

  
      
    
  

  
      

  
    Contributor


      

  

  
    
      

      
            archmoj
  

      

      

      


        Jan 3, 2024


      
    

  


        
      
  
  
  
    

    There was a problem hiding this comment.


  

 
  
    

    Choose a reason for hiding this comment

    
      The reason will be displayed to describe this comment to others. Learn more.
    

    
      
      


  


  
    
      Let's use Lib.pseudoRandom as well as Lib.seedPseudoRandom as it applied by other jasmine tests.
    
  
  


    

        
      
  
  
    
  
  
  
    
    Sorry, something went wrong.
  

  
    
  
    
      

              Uh oh!

              
There was an error while loading. Please reload this page.


  
  


          
      
  
    
    
      
        
            
    All reactions
-          var n = Math.floor(Math.random() * 99) + 1;
+          Lib.seedPseudoRandom();
+          var n = (Lib.pseudoRandom() * 99) + 1;
           tickVals = [];
           for(let i = 0; i <= n; i++) {
             tickVals.push(i);
-          Expand Down