Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Reorganise gl tests for less flakiness #3859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 13, 2019
Merged

Reorganise gl tests for less flakiness #3859

merged 10 commits into from
May 13, 2019

Conversation

etpinard
Copy link
Contributor

my follow-up on #3853 (comment) which appears to make our flaky @gl tests less flaky (3/3 successful runs so far).

In brief,

  • The hover/click tests in gl3d_plot_interact_test.js are moved to new suite gl3d_hover_click_test.js
  • scattergl interactions tests are divided up evenly (and logically) in gl2d_plot_interact_test.js, scattergl_test.js and scattergl_select_test.js

cc @plotly/plotly_js It's the not the end of the story, but this PR should be a solid step forward toward non-flaky @gl tests.

@archmoj
Copy link
Contributor

archmoj commented May 13, 2019

💃 💃
💃 💃

@etpinard etpinard merged commit d617a1b into master May 13, 2019
@etpinard etpinard deleted the flaky-gl-ci-fixes branch May 13, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.