ensuring special cases 0 rows or 0 columns work; noOpacity

plotly · etpinard · Oct 23, 2017 · Oct 16, 2017 · Oct 16, 2017 · Oct 17, 2017
commit 3d56195d5f5eef1694ab735d32c8e8ca0b5359d4
diff --git a/src/traces/table/data_preparation_helper.js b/src/traces/table/data_preparation_helper.js
@@ -16,11 +16,12 @@ module.exports = function calc(gd, trace) {
    var headerValues = trace.header.values.map(function(c) {
        return Array.isArray(c) ? c : [c];
    });
+    var cellsValues = trace.cells.values;
    var domain = trace.domain;
    var groupWidth = Math.floor(gd._fullLayout._size.w * (domain.x[1] - domain.x[0]));
    var groupHeight = Math.floor(gd._fullLayout._size.h * (domain.y[1] - domain.y[0]));
-    var headerRowHeights = headerValues[0].map(function() {return trace.header.height;});
-    var rowHeights = trace.cells.values[0].map(function() {return trace.cells.height;});
+    var headerRowHeights = headerValues.length ? headerValues[0].map(function() {return trace.header.height;}) : [];
+    var rowHeights = cellsValues.length ? cellsValues[0].map(function() {return trace.cells.height;}) : [];
    var headerHeight = headerRowHeights.reduce(function(a, b) {return a + b;}, 0);
    var scrollHeight = groupHeight - headerHeight;
    var minimumFillHeight = scrollHeight + c.uplift;

diff --git a/src/traces/table/defaults.js b/src/traces/table/defaults.js
@@ -11,9 +11,9 @@
 var Lib = require('../../lib');
 var attributes = require('./attributes');

-function defaultColumnOrder(traceIn, coerce) {
-    var specifiedColumnOrder = traceIn.columnorder || [];
-    var commonLength = traceIn.header.values.length;
+function defaultColumnOrder(traceOut, coerce) {
+    var specifiedColumnOrder = traceOut.columnorder || [];
+    var commonLength = traceOut.header.values.length;
    var truncated = specifiedColumnOrder.slice(0, commonLength);
    var sorted = truncated.slice().sort(function(a, b) {return a - b;});
    var oneStepped = truncated.map(function(d) {return sorted.indexOf(d);});
@@ -28,28 +28,10 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
        return Lib.coerce(traceIn, traceOut, attributes, attr, dflt);
    }

-    var fontDflt = {
-        family: layout.font.family,
-        size: layout.font.size,
-        color: layout.font.color
-    };
-
    coerce('domain.x');
    coerce('domain.y');

    coerce('columnwidth');
-    defaultColumnOrder(traceIn, coerce);
-
-    coerce('cells.values');
-    coerce('cells.format');
-    coerce('cells.align');
-    coerce('cells.prefix');
-    coerce('cells.suffix');
-    coerce('cells.height');
-    coerce('cells.line.width');
-    coerce('cells.line.color');
-    coerce('cells.fill.color');
-    Lib.coerceFont(coerce, 'cells.font', fontDflt);

    coerce('header.values');
    coerce('header.format');
@@ -60,6 +42,19 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
    coerce('header.height');
    coerce('header.line.width');
    coerce('header.line.color');
-    coerce('header.fill.color');
-    Lib.coerceFont(coerce, 'header.font', fontDflt);
+    coerce('header.fill.color', defaultColor);
+    Lib.coerceFont(coerce, 'header.font', Lib.extendFlat({}, layout.font));
+
+    defaultColumnOrder(traceOut, coerce);
+
+    coerce('cells.values');
+    coerce('cells.format');
+    coerce('cells.align');
+    coerce('cells.prefix');
+    coerce('cells.suffix');
+    coerce('cells.height');
+    coerce('cells.line.width');
+    coerce('cells.line.color');
+    coerce('cells.fill.color', defaultColor);
+    Lib.coerceFont(coerce, 'cells.font', Lib.extendFlat({}, layout.font));
 };
diff --git a/src/traces/table/index.js b/src/traces/table/index.js
@@ -18,7 +18,7 @@ Table.plot = require('./plot');
 Table.moduleType = 'trace';
 Table.name = 'table';
 Table.basePlotModule = require('./base_plot');
-Table.categories = [];
+Table.categories = ['noOpacity'];
 Table.meta = {
    description: [
        'Table view for detailed data viewing.',