Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Drawing bbox fix for window scroll #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 16, 2017
Merged

Drawing bbox fix for window scroll #1683

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
83b3d64
Revert "Cache DOM nodes and selected d3 node"
etpinard May 12, 2017
9af534a
add drawing bb test
etpinard May 12, 2017
3fdb308
make bbox test more robust
etpinard May 15, 2017
0c62890
cache ref to tester div and tester ref on drawing module object
etpinard May 15, 2017
273a4c3
cache DOMParser instance on svg utils module object
etpinard May 15, 2017
e0050f7
don't expose DOMParser instance on svg utils module object
etpinard May 16, 2017
c3c3b3a
:hocho: gd._testref (wasn't used anywhere)
etpinard May 16, 2017
a8fba03
replace gd._tester with drawing._tester
etpinard May 16, 2017
66259ed
Merge pull request #1690 from plotly/drawing-perf-take2
etpinard May 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
don't expose DOMParser instance on svg utils module object
  • Loading branch information
@etpinard
etpinard committed May 16, 2017
commit e0050f73c57c54755a6131584b152151bf0c7c06
10 changes: 6 additions & 4 deletions 10 src/lib/svg_text_utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,14 @@ var Lib = require('../lib');
var xmlnsNamespaces = require('../constants/xmlns_namespaces');
var stringMappings = require('../constants/string_mappings');

var DOM_PARSER;

exports.getDOMParser = function() {
if(exports.domParser) {
return exports.domParser;
if(DOM_PARSER) {
return DOM_PARSER;
} else if(window.DOMParser) {
exports.domParser = new window.DOMParser();
return exports.domParser;
DOM_PARSER = new window.DOMParser();
return DOM_PARSER;
} else {
throw new Error('Cannot initialize DOMParser');
}
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.