remove transforms attribute from PlotSchema for traces that don't support them

In the process of reviewing PR #3158, @etpinard pointed out that some traces don't support transforms yet it's listed in their PlotSchema (#3158 (comment))

Note that they are properly removed from _fullData:

plotly.js/src/plots/plots.js

Lines 1224 to 1230 in 0124828

    
           plots.supplyTransformDefaults = function(traceIn, traceOut, layout) { 
        
               // For now we only allow transforms on 1D traces, ie those that specify a _length. 
        
               // If we were to implement 2D transforms, we'd need to have each transform 
        
               // describe its own applicability and disable itself when it doesn't apply. 
        
               // Also allow transforms that make their own data, but not in globalTransforms 
        
               if(!(traceOut._length || hasMakesDataTransform(traceIn))) return;

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

remove `transforms` attribute from PlotSchema for traces that don't support them #3188

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	plots.supplyTransformDefaults = function(traceIn, traceOut, layout) {
	// For now we only allow transforms on 1D traces, ie those that specify a _length.
	// If we were to implement 2D transforms, we'd need to have each transform
	// describe its own applicability and disable itself when it doesn't apply.
	// Also allow transforms that make their own data, but not in globalTransforms
	if(!(traceOut._length \|\| hasMakesDataTransform(traceIn))) return;

Search code, repositories, users, issues, pull requests...

Uh oh!

remove transforms attribute from PlotSchema for traces that don't support them #3188

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

remove `transforms` attribute from PlotSchema for traces that don't support them #3188