Closed
Description
On CircleCI publish happens right after the build job.
The build job on the CI is npm run cibuild which doesn't update the plot-schema.json. We should update it either by:
- adding code to https://github.com/plotly/plotly.js/blob/master/tasks/cibundle.js
- creating a new task only for that purpose which would only be executed in the
publishjob.
Option 1 adds 15 seconds to the build step. So I would favor option 2 since it can be runned in parallel.
Poor's man benchmark
master
[antoine@newton:~/plotly/plotly.js]$ time npm run cibuild
> plotly.js@1.41.3 cibuild /home/antoine/plotly/plotly.js
> npm run preprocess && node tasks/cibundle.js
###
> plotly.js@1.41.3 preprocess /home/antoine/plotly/plotly.js
> node tasks/preprocess.js
ok plotly-geo-assets.js
ok plotly.js
ok plotly.min.js
real 0m39.960s
user 0m59.195s
sys 0m2.339s
Option 1
[antoine@newton:~/plotly/plotly.js]$ time npm run cibuild
> plotly.js@1.41.3 cibuild /home/antoine/plotly/plotly.js
> npm run preprocess && node tasks/cibundle.js
> plotly.js@1.41.3 preprocess /home/antoine/plotly/plotly.js
> node tasks/preprocess.js
ok plotly-geo-assets.js
ok plotly-with-meta.js
ok plot-schema.json
ok plotly.js
ok plotly.min.js
real 0m53.048s
user 1m21.699s
sys 0m3.376s
Metadata
Metadata
Assignees
Labels
something brokensomething broken