Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Prune unsupported global-level trace attributes #3058

Copy link
Copy link
Closed
@alexcjohnson

Description

@alexcjohnson
Issue body actions

There are a bunch of attributes that we insert in the schema, and largely include in _fullData for all trace types. But many trace types don't support all of these attributes. As a simple workaround in @jonmmease's parcats PR, 273d2d0 (following @etpinard's suggestion #2963 (comment)) hides a the ones parcats doesn't use from the schema, but they will still show up in _fullData.

As I said in #2963 (comment):

There's a module categories: ['noOpacity'] which prevents coercing opacity (so it's not in fullData, which is important for the editor) but does not take it out of the schema (and anyway only handles opacity). @etpinard 's solution would fix the schema but not fullData. Sounds like what we really want is something like:

module.omitGlobalAttrs: ['selectedpoints', 'hoverlabel', 'opacity', 'ids', 'customdata']

that would do both.

There are probably quite a few other traces that omit some of these - in fact, probably everything that sets traceOut._length = null has no use for selectedpoints, ids, and customdata...

And @etpinard responded #2963 (comment):

Good point here. But I think for this PR my suggestion in #2963 (comment) will be good enough. The react-chart-editor (aka RCE) doesn't know how to handle traces with dimensions yet, so having a few extra keys in fullData won't affect anyone at this stage. But yeah, once merged we should open a new issue (similar to #2834 and #2908) about this.

So here's that issue :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.