Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit df5e121

Browse filesBrowse files
committed
only return label from the helper - set the label of dummy root to blank
1 parent 422d5d3 commit df5e121
Copy full SHA for df5e121

File tree

Expand file treeCollapse file tree

4 files changed

+5
-5
lines changed
Filter options
Expand file treeCollapse file tree

4 files changed

+5
-5
lines changed

‎src/traces/sunburst/calc.js

Copy file name to clipboardExpand all lines: src/traces/sunburst/calc.js
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,8 @@ exports.calc = function(gd, trace) {
128128
cd.unshift({
129129
hasMultipleRoots: true,
130130
id: dummyId,
131-
pid: ''
131+
pid: '',
132+
label: ''
132133
});
133134
}
134135

‎src/traces/sunburst/helpers.js

Copy file name to clipboardExpand all lines: src/traces/sunburst/helpers.js
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,7 @@ exports.getPtId = function(pt) {
5252
};
5353

5454
exports.getPtLabel = function(pt) {
55-
var label = pt.data.data.label;
56-
return label === undefined ? pt.data.data.pid : label;
55+
return pt.data.data.label;
5756
};
5857

5958
exports.getValue = function(d) {

‎test/jasmine/tests/sunburst_test.js

Copy file name to clipboardExpand all lines: test/jasmine/tests/sunburst_test.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ describe('Test sunburst calc:', function() {
235235

236236
expect(extract('id')).toEqual(['dummy', 'A', 'B', 'b']);
237237
expect(extract('pid')).toEqual(['', 'dummy', 'dummy', 'B']);
238-
expect(extract('label')).toEqual([undefined, 'A', 'B', 'b']);
238+
expect(extract('label')).toEqual(['', 'A', 'B', 'b']);
239239
});
240240

241241
it('should compute hierarchy values', function() {

‎test/jasmine/tests/treemap_test.js

Copy file name to clipboardExpand all lines: test/jasmine/tests/treemap_test.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ describe('Test treemap calc:', function() {
346346

347347
expect(extract('id')).toEqual(['dummy', 'A', 'B', 'b']);
348348
expect(extract('pid')).toEqual(['', 'dummy', 'dummy', 'B']);
349-
expect(extract('label')).toEqual([undefined, 'A', 'B', 'b']);
349+
expect(extract('label')).toEqual(['', 'A', 'B', 'b']);
350350
});
351351

352352
it('should compute hierarchy values', function() {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.