Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d8441a0

Browse filesBrowse files
authored
Merge pull request #1394 from plotly/bump-dev-deps
Bump dev deps
2 parents a8a2752 + 2b57297 commit d8441a0
Copy full SHA for d8441a0

File tree

Expand file treeCollapse file tree

2 files changed

+21
-13
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+21
-13
lines changed

‎package.json

Copy file name to clipboardExpand all lines: package.json
+8-8Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -94,34 +94,34 @@
9494
},
9595
"devDependencies": {
9696
"brfs": "^1.4.3",
97-
"browserify": "^13.3.0",
97+
"browserify": "^14.1.0",
9898
"browserify-transform-tools": "^1.7.0",
9999
"deep-equal": "^1.0.1",
100100
"ecstatic": "^2.1.0",
101-
"eslint": "^3.13.0",
101+
"eslint": "^3.15.0",
102102
"falafel": "^2.0.0",
103-
"fs-extra": "^1.0.0",
103+
"fs-extra": "^2.0.0",
104104
"fuse.js": "^2.6.1",
105105
"glob": "^7.0.0",
106106
"gzip-size": "^3.0.0",
107107
"image-size": "^0.5.1",
108108
"jasmine-core": "^2.4.1",
109-
"karma": "^1.1.0",
110-
"karma-browserify": "^5.0.1",
109+
"karma": "^1.4.1",
110+
"karma-browserify": "^5.1.1",
111111
"karma-chrome-launcher": "^2.0.0",
112112
"karma-coverage": "^1.0.0",
113113
"karma-firefox-launcher": "^1.0.0",
114114
"karma-jasmine": "^1.1.0",
115-
"madge": "^1.4.4",
116-
"node-sass": "^4.1.1",
115+
"madge": "^1.6.0",
116+
"node-sass": "^4.5.0",
117117
"npm-link-check": "^1.2.0",
118118
"open": "0.0.5",
119119
"prepend-file": "^1.3.1",
120120
"prettysize": "0.0.3",
121121
"requirejs": "^2.3.1",
122122
"through2": "^2.0.3",
123123
"uglify-js": "^2.7.5",
124-
"watchify": "^3.8.0",
124+
"watchify": "^3.9.0",
125125
"xml2js": "^0.4.16"
126126
}
127127
}

‎tasks/test_syntax.js

Copy file name to clipboardExpand all lines: tasks/test_syntax.js
+13-5Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ var libGlob = path.join(constants.pathToLib, '**/*.js');
1111
var testGlob = path.join(constants.pathToJasmineTests, '**/*.js');
1212
var bundleTestGlob = path.join(constants.pathToJasmineBundleTests, '**/*.js');
1313

14+
var EXIT_CODE = 0;
15+
1416
// main
1517
assertJasmineSuites();
1618
assertSrcContents();
@@ -117,7 +119,7 @@ function assertCircularDeps() {
117119
// as of v1.17.0 - 2016/09/08
118120
// see https://github.com/plotly/plotly.js/milestone/9
119121
// for more details
120-
var MAX_ALLOWED_CIRCULAR_DEPS = 17;
122+
var MAX_ALLOWED_CIRCULAR_DEPS = 18;
121123

122124
if(circularDeps.length > MAX_ALLOWED_CIRCULAR_DEPS) {
123125
logs.push('some new circular dependencies were added to src/');
@@ -133,9 +135,15 @@ function combineGlobs(arr) {
133135

134136
function log(name, logs) {
135137
if(logs.length) {
136-
console.error('test-syntax error [' + name + ']\n');
137-
throw new Error('\n' + logs.join('\n') + '\n');
138+
console.error('test-syntax error [' + name + ']');
139+
EXIT_CODE = 1;
140+
} else {
141+
console.log('ok ' + name);
138142
}
139-
140-
console.log('ok ' + name);
141143
}
144+
145+
process.on('exit', function() {
146+
if(EXIT_CODE) {
147+
throw new Error('test syntax failed.');
148+
}
149+
});

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.