Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 656a07c

Browse filesBrowse files
authored
Merge pull request #7367 from iisakkirotko/prevent-amd-check
Ensure AMD headers of dependencies aren't kept in bundle
2 parents 08da201 + 41900d0 commit 656a07c
Copy full SHA for 656a07c

File tree

2 files changed

+2
-0
lines changed
Filter options

2 files changed

+2
-0
lines changed

‎draftlogs/7367_fix.md

Copy file name to clipboard
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- Fix importing plotly.js via require on pages with [AMD](https://en.wikipedia.org/wiki/Asynchronous_module_definition) [[#7367](https://github.com/plotly/plotly.js/pull/7367)]

‎esbuild-config.js

Copy file name to clipboardExpand all lines: esbuild-config.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ module.exports = {
2323
},
2424
define: {
2525
global: 'window',
26+
'define.amd': 'false',
2627
},
2728
target: 'es2016',
2829
logLevel: 'info',

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.