Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 5d930ce

Browse filesBrowse files
alexcjohnsonalexcjohnson
committed
_module.cleanData -> crossTraceDefaults
1 parent 76eee4b commit 5d930ce
Copy full SHA for 5d930ce

File tree

Expand file treeCollapse file tree

11 files changed

+17
-17
lines changed
Filter options
Expand file treeCollapse file tree

11 files changed

+17
-17
lines changed

‎src/plots/plots.js

Copy file name to clipboardExpand all lines: src/plots/plots.js
+7-7Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -438,17 +438,17 @@ plots.supplyDefaults = function(gd, opts) {
438438
plots.supplyLayoutModuleDefaults(newLayout, newFullLayout, newFullData, gd._transitionData);
439439

440440
// Special cases that introduce interactions between traces.
441-
// This is after relinkPrivateKeys so we can use those in cleanData
441+
// This is after relinkPrivateKeys so we can use those in crossTraceDefaults
442442
// and after layout module defaults, so we can use eg barmode
443443
var _modules = newFullLayout._visibleModules;
444-
var cleanDataFuncs = [];
444+
var crossTraceDefaultsFuncs = [];
445445
for(i = 0; i < _modules.length; i++) {
446-
var _module = _modules[i];
447-
// some trace types share cleanData (ie histogram2d, histogram2dcontour)
448-
if(_module.cleanData) Lib.pushUnique(cleanDataFuncs, _module.cleanData);
446+
var funci = _modules[i].crossTraceDefaults;
447+
// some trace types share crossTraceDefaults (ie histogram2d, histogram2dcontour)
448+
if(funci) Lib.pushUnique(crossTraceDefaultsFuncs, funci);
449449
}
450-
for(i = 0; i < cleanDataFuncs.length; i++) {
451-
cleanDataFuncs[i](newFullData, newFullLayout);
450+
for(i = 0; i < crossTraceDefaultsFuncs.length; i++) {
451+
crossTraceDefaultsFuncs[i](newFullData, newFullLayout);
452452
}
453453

454454
// turn on flag to optimize large splom-only graphs

‎src/traces/histogram/clean_data.js renamed to ‎src/traces/histogram/cross_trace_defaults.js

Copy file name to clipboardExpand all lines: src/traces/histogram/cross_trace_defaults.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ var BINATTRS = {
3030
};
3131

3232
// handle bin attrs and relink auto-determined values so fullData is complete
33-
module.exports = function cleanData(fullData, fullLayout) {
33+
module.exports = function crossTraceDefaults(fullData, fullLayout) {
3434
var allBinOpts = fullLayout._histogramBinOpts = {};
3535
var isOverlay = fullLayout.barmode === 'overlay';
3636
var i, j, traceOut, traceIn, binDirection, group, binOpts;

‎src/traces/histogram/defaults.js

Copy file name to clipboardExpand all lines: src/traces/histogram/defaults.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
5252
if(hasAggregationData) coerce('histfunc');
5353
coerce('histnorm');
5454

55-
// Note: bin defaults are now handled in Histogram.cleanData
55+
// Note: bin defaults are now handled in Histogram.crossTraceDefaults
5656
// autobin(x|y) are only included here to appease Plotly.validate
5757
coerce('autobin' + sampleLetter);
5858

‎src/traces/histogram/index.js

Copy file name to clipboardExpand all lines: src/traces/histogram/index.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ var Histogram = {};
2828
Histogram.attributes = require('./attributes');
2929
Histogram.layoutAttributes = require('../bar/layout_attributes');
3030
Histogram.supplyDefaults = require('./defaults');
31-
Histogram.cleanData = require('./clean_data');
31+
Histogram.crossTraceDefaults = require('./cross_trace_defaults');
3232
Histogram.supplyLayoutDefaults = require('../bar/layout_defaults');
3333
Histogram.calc = require('./calc');
3434
Histogram.crossTraceCalc = require('../bar/cross_trace_calc').crossTraceCalc;

‎src/traces/histogram2d/clean_data.js renamed to ‎src/traces/histogram2d/cross_trace_defaults.js

Copy file name to clipboardExpand all lines: src/traces/histogram2d/cross_trace_defaults.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ var BINDIRECTIONS = ['x', 'y'];
2323
// Handle bin attrs and relink auto-determined values so fullData is complete
2424
// does not have cross-trace coupling, but moved out here so we have axis types
2525
// and relinked trace._autoBin
26-
module.exports = function cleanData(fullData, fullLayout) {
26+
module.exports = function crossTraceDefaults(fullData, fullLayout) {
2727
var i, j, traceOut, binDirection;
2828

2929
function coerce(attr) {

‎src/traces/histogram2d/index.js

Copy file name to clipboardExpand all lines: src/traces/histogram2d/index.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ var Histogram2D = {};
1313

1414
Histogram2D.attributes = require('./attributes');
1515
Histogram2D.supplyDefaults = require('./defaults');
16-
Histogram2D.cleanData = require('./clean_data');
16+
Histogram2D.crossTraceDefaults = require('./cross_trace_defaults');
1717
Histogram2D.calc = require('../heatmap/calc');
1818
Histogram2D.plot = require('../heatmap/plot');
1919
Histogram2D.layerName = 'heatmaplayer';

‎src/traces/histogram2d/sample_defaults.js

Copy file name to clipboardExpand all lines: src/traces/histogram2d/sample_defaults.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ module.exports = function handleSampleDefaults(traceIn, traceOut, coerce, layout
3434
if(hasAggregationData) coerce('histfunc');
3535
coerce('histnorm');
3636

37-
// Note: bin defaults are now handled in Histogram2D.cleanData
37+
// Note: bin defaults are now handled in Histogram2D.crossTraceDefaults
3838
// autobin(x|y) are only included here to appease Plotly.validate
3939
coerce('autobinx');
4040
coerce('autobiny');

‎src/traces/histogram2dcontour/index.js

Copy file name to clipboardExpand all lines: src/traces/histogram2dcontour/index.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ var Histogram2dContour = {};
1313

1414
Histogram2dContour.attributes = require('./attributes');
1515
Histogram2dContour.supplyDefaults = require('./defaults');
16-
Histogram2dContour.cleanData = require('../histogram2d/clean_data');
16+
Histogram2dContour.crossTraceDefaults = require('../histogram2d/cross_trace_defaults');
1717
Histogram2dContour.calc = require('../contour/calc');
1818
Histogram2dContour.plot = require('../contour/plot').plot;
1919
Histogram2dContour.layerName = 'contourlayer';

‎src/traces/scatter/clean_data.js renamed to ‎src/traces/scatter/cross_trace_defaults.js

Copy file name to clipboardExpand all lines: src/traces/scatter/cross_trace_defaults.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212

1313
// remove opacity for any trace that has a fill or is filled to
14-
module.exports = function cleanData(fullData) {
14+
module.exports = function crossTraceDefaults(fullData) {
1515
for(var i = 0; i < fullData.length; i++) {
1616
var tracei = fullData[i];
1717
if(tracei.type !== 'scatter') continue;

‎src/traces/scatter/index.js

Copy file name to clipboardExpand all lines: src/traces/scatter/index.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Scatter.isBubble = subtypes.isBubble;
1919

2020
Scatter.attributes = require('./attributes');
2121
Scatter.supplyDefaults = require('./defaults');
22-
Scatter.cleanData = require('./clean_data');
22+
Scatter.crossTraceDefaults = require('./cross_trace_defaults');
2323
Scatter.calc = require('./calc').calc;
2424
Scatter.crossTraceCalc = require('./cross_trace_calc');
2525
Scatter.arraysToCalcdata = require('./arrays_to_calcdata');

‎src/traces/scattergl/index.js

Copy file name to clipboardExpand all lines: src/traces/scattergl/index.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -952,7 +952,7 @@ module.exports = {
952952

953953
attributes: require('./attributes'),
954954
supplyDefaults: require('./defaults'),
955-
cleanData: require('../scatter/clean_data'),
955+
crossTraceDefaults: require('../scatter/cross_trace_defaults'),
956956
colorbar: require('../scatter/marker_colorbar'),
957957
calc: calc,
958958
plot: plot,

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.