Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 3542cc5

Browse filesBrowse files
authored
Merge pull request #7078 from birkskyum/Use-node.js-v18-and-npm-v10-in-development
Use `node.js v18` and `npm v10` in development
2 parents e02185f + e0eafc8 commit 3542cc5
Copy full SHA for 3542cc5

File tree

Expand file treeCollapse file tree

4 files changed

+25
-23
lines changed
Filter options
Expand file treeCollapse file tree

4 files changed

+25
-23
lines changed

‎.circleci/config.yml

Copy file name to clipboardExpand all lines: .circleci/config.yml
+20-20Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ jobs:
2626
name: CI-Build
2727
command: npm run cibuild
2828

29-
install-and-cibuild: # main cibuild using node 16 & npm 7
29+
install-and-cibuild:
3030
docker:
31-
- image: cimg/node:16.20.2
31+
- image: cimg/node:18.20.4
3232
working_directory: ~/plotly.js
3333
steps:
3434
- checkout
@@ -52,7 +52,7 @@ jobs:
5252
timezone-jasmine:
5353
docker:
5454
# need '-browsers' version to test in real (xvfb-wrapped) browsers
55-
- image: cimg/node:16.20.2-browsers
55+
- image: cimg/node:18.20.4-browsers
5656
working_directory: ~/plotly.js
5757
steps:
5858
- browser-tools/install-browser-tools: &browser-versions
@@ -84,7 +84,7 @@ jobs:
8484
no-gl-jasmine:
8585
docker:
8686
# need '-browsers' version to test in real (xvfb-wrapped) browsers
87-
- image: cimg/node:16.20.2-browsers
87+
- image: cimg/node:18.20.4-browsers
8888
environment:
8989
# Alaska time (arbitrary timezone to test date logic)
9090
TZ: "America/Anchorage"
@@ -103,7 +103,7 @@ jobs:
103103
webgl-jasmine:
104104
docker:
105105
# need '-browsers' version to test in real (xvfb-wrapped) browsers
106-
- image: cimg/node:16.20.2-browsers
106+
- image: cimg/node:18.20.4-browsers
107107
environment:
108108
# Alaska time (arbitrary timezone to test date logic)
109109
TZ: "America/Anchorage"
@@ -122,7 +122,7 @@ jobs:
122122
virtual-webgl-jasmine:
123123
docker:
124124
# need '-browsers' version to test in real (xvfb-wrapped) browsers
125-
- image: cimg/node:16.20.2-browsers
125+
- image: cimg/node:18.20.4-browsers
126126
environment:
127127
# Alaska time (arbitrary timezone to test date logic)
128128
TZ: "America/Anchorage"
@@ -141,7 +141,7 @@ jobs:
141141
flaky-no-gl-jasmine:
142142
docker:
143143
# need '-browsers' version to test in real (xvfb-wrapped) browsers
144-
- image: cimg/node:16.20.2-browsers
144+
- image: cimg/node:18.20.4-browsers
145145
environment:
146146
# Alaska time (arbitrary timezone to test date logic)
147147
TZ: "America/Anchorage"
@@ -159,7 +159,7 @@ jobs:
159159
bundle-jasmine:
160160
docker:
161161
# need '-browsers' version to test in real (xvfb-wrapped) browsers
162-
- image: cimg/node:16.20.2-browsers
162+
- image: cimg/node:18.20.4-browsers
163163
environment:
164164
# Alaska time (arbitrary timezone to test date logic)
165165
TZ: "America/Anchorage"
@@ -177,7 +177,7 @@ jobs:
177177
mathjax-firefoxLatest:
178178
docker:
179179
# need '-browsers' version to test in real (xvfb-wrapped) browsers
180-
- image: cimg/node:16.20.2-browsers
180+
- image: cimg/node:18.20.4-browsers
181181
environment:
182182
# Alaska time (arbitrary timezone to test date logic)
183183
TZ: "America/Anchorage"
@@ -269,7 +269,7 @@ jobs:
269269

270270
test-baselines:
271271
docker:
272-
- image: cimg/node:16.20.2
272+
- image: cimg/node:18.20.4
273273
working_directory: ~/plotly.js
274274
steps:
275275
- attach_workspace:
@@ -283,7 +283,7 @@ jobs:
283283

284284
test-baselines-virtual-webgl:
285285
docker:
286-
- image: cimg/node:16.20.2
286+
- image: cimg/node:18.20.4
287287
working_directory: ~/plotly.js
288288
steps:
289289
- attach_workspace:
@@ -297,7 +297,7 @@ jobs:
297297

298298
test-baselines-b64:
299299
docker:
300-
- image: cimg/node:16.20.2
300+
- image: cimg/node:18.20.4
301301
working_directory: ~/plotly.js
302302
steps:
303303
- attach_workspace:
@@ -311,7 +311,7 @@ jobs:
311311

312312
test-baselines-mathjax3:
313313
docker:
314-
- image: cimg/node:16.20.2
314+
- image: cimg/node:18.20.4
315315
working_directory: ~/plotly.js
316316
steps:
317317
- attach_workspace:
@@ -336,8 +336,8 @@ jobs:
336336
- run:
337337
name: Install poppler-utils to have pdftops for exporting eps
338338
command: |
339-
sudo apt-get update --allow-releaseinfo-change
340-
sudo apt-get install poppler-utils
339+
sudo apt-get update --allow-releaseinfo-change
340+
sudo apt-get install poppler-utils
341341
- run:
342342
name: Create svg, jpg, jpeg, webp, pdf and eps files
343343
command: python3 test/image/make_exports.py
@@ -348,7 +348,7 @@ jobs:
348348

349349
test-exports:
350350
docker:
351-
- image: cimg/node:16.20.2
351+
- image: cimg/node:18.20.4
352352
working_directory: ~/plotly.js
353353
steps:
354354
- attach_workspace:
@@ -362,7 +362,7 @@ jobs:
362362

363363
mock-validation:
364364
docker:
365-
- image: cimg/node:16.20.2
365+
- image: cimg/node:18.20.4
366366
working_directory: ~/plotly.js
367367
steps:
368368
- attach_workspace:
@@ -376,7 +376,7 @@ jobs:
376376

377377
source-syntax:
378378
docker:
379-
- image: cimg/node:16.20.2
379+
- image: cimg/node:18.20.4
380380
working_directory: ~/plotly.js
381381
steps:
382382
- attach_workspace:
@@ -387,7 +387,7 @@ jobs:
387387

388388
publish-dist:
389389
docker:
390-
- image: cimg/node:16.20.2
390+
- image: cimg/node:18.20.4
391391
working_directory: ~/plotly.js
392392
steps:
393393
- checkout
@@ -457,7 +457,7 @@ jobs:
457457

458458
test-stackgl-bundle:
459459
docker:
460-
- image: cimg/node:16.20.2
460+
- image: cimg/node:18.20.4
461461
working_directory: ~/plotly.js
462462
steps:
463463
- checkout

‎CONTRIBUTING.md

Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,10 @@ We use the following [labels](https://github.com/plotly/plotly.js/labels) to tra
7777
#### Prerequisites
7878

7979
- git
80-
- [node.js](https://nodejs.org/en/). We recommend using node.js v16.x.
80+
- [node.js](https://nodejs.org/en/). We recommend using node.js v18.x.
8181
Upgrading and managing node versions can be easily done using
8282
[`nvm`](https://github.com/creationix/nvm) or its Windows alternatives.
83-
- [`npm`](https://www.npmjs.com/) v7.x and up to ensure that the
83+
- [`npm`](https://www.npmjs.com/) v10.x and up to ensure that the
8484
[`package-lock.json`](https://docs.npmjs.com/files/package-lock.json) file is
8585
used and updated correctly.
8686
- [`python3`](https://www.python.org/downloads/)

‎draftlogs/7078_change.md

Copy file name to clipboard
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
- Use `Node.js v18` and `npm v10` in development [[#5922](https://github.com/plotly/plotly.js/pull/5922), [#7078](https://github.com/plotly/plotly.js/pull/7078)]
2+

‎package.json

Copy file name to clipboardExpand all lines: package.json
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
"start": "node devtools/test_dashboard/server.js",
6060
"baseline": "node test/image/make_baseline.js",
6161
"noci-baseline": "npm run cibuild && ./tasks/noci_test.sh image && git checkout dist && echo 'Please do not commit unless the change was expected!'",
62-
"preversion": "check-node-version --node 16 --npm 8 && npm-link-check && npm ls --prod --all",
62+
"preversion": "check-node-version --node 18 --npm 10 && npm-link-check && npm ls --prod --all",
6363
"version": "npm run build && npm run no-bad-char && git add -A lib dist build src/version.js",
6464
"postversion": "node -e \"console.log('Version bumped and committed. If ok, run: git push && git push --tags')\"",
6565
"postpublish": "node tasks/sync_packages.js",

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.