Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 0ad7cfa

Browse filesBrowse files
authored
Merge pull request #7214 from plotly/drop-bardir
Drop support for deprecated `bardir` attribute (use `orientation` instead)
2 parents d5d3712 + 093ae80 commit 0ad7cfa
Copy full SHA for 0ad7cfa

File tree

5 files changed

+1
-46
lines changed
Filter options

5 files changed

+1
-46
lines changed

‎draftlogs/7214_remove.md

Copy file name to clipboard
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Drop support for deprecated `bardir` attribute (use `orientation` instead) [[#7214](https://github.com/plotly/plotly.js/pull/7214)]

‎src/plot_api/helpers.js

Copy file name to clipboardExpand all lines: src/plot_api/helpers.js
-11Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -295,17 +295,6 @@ exports.cleanData = function(data) {
295295
delete trace.error_y.opacity;
296296
}
297297

298-
// convert bardir to orientation, and put the data into
299-
// the axes it's eventually going to be used with
300-
if('bardir' in trace) {
301-
if(trace.bardir === 'h' && (traceIs(trace, 'bar') ||
302-
trace.type.substr(0, 9) === 'histogram')) {
303-
trace.orientation = 'h';
304-
exports.swapXYData(trace);
305-
}
306-
delete trace.bardir;
307-
}
308-
309298
// now we have only one 1D histogram type, and whether
310299
// it uses x or y data depends on trace.orientation
311300
if(trace.type === 'histogramy') exports.swapXYData(trace);

‎src/traces/bar/attributes.js

Copy file name to clipboardExpand all lines: src/traces/bar/attributes.js
-9Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -227,13 +227,4 @@ module.exports = {
227227
editType: 'style'
228228
},
229229
zorder: scatterAttrs.zorder,
230-
231-
_deprecated: {
232-
bardir: {
233-
valType: 'enumerated',
234-
editType: 'calc',
235-
values: ['v', 'h'],
236-
description: 'Renamed to `orientation`.'
237-
}
238-
}
239230
};

‎src/traces/histogram/attributes.js

Copy file name to clipboardExpand all lines: src/traces/histogram/attributes.js
-4Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -246,9 +246,5 @@ module.exports = {
246246
selected: barAttrs.selected,
247247
unselected: barAttrs.unselected,
248248

249-
_deprecated: {
250-
bardir: barAttrs._deprecated.bardir
251-
},
252-
253249
zorder: barAttrs.zorder
254250
};

‎test/plot-schema.json

Copy file name to clipboardExpand all lines: test/plot-schema.json
-22Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -17291,17 +17291,6 @@
1729117291
"bar": {
1729217292
"animatable": true,
1729317293
"attributes": {
17294-
"_deprecated": {
17295-
"bardir": {
17296-
"description": "Renamed to `orientation`.",
17297-
"editType": "calc",
17298-
"valType": "enumerated",
17299-
"values": [
17300-
"v",
17301-
"h"
17302-
]
17303-
}
17304-
},
1730517294
"alignmentgroup": {
1730617295
"description": "Set several traces linked to the same position axis or matching axes to the same alignmentgroup. This controls whether bars compute their positional range dependently or independently.",
1730717296
"dflt": "",
@@ -43700,17 +43689,6 @@
4370043689
"histogram": {
4370143690
"animatable": false,
4370243691
"attributes": {
43703-
"_deprecated": {
43704-
"bardir": {
43705-
"description": "Renamed to `orientation`.",
43706-
"editType": "calc",
43707-
"valType": "enumerated",
43708-
"values": [
43709-
"v",
43710-
"h"
43711-
]
43712-
}
43713-
},
4371443692
"alignmentgroup": {
4371543693
"description": "Set several traces linked to the same position axis or matching axes to the same alignmentgroup. This controls whether bars compute their positional range dependently or independently.",
4371643694
"dflt": "",

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.