fix error on clearing crosstalk selection

plotly · casperhart · Jan 9, 2022 · Apr 24, 2022 · cd634244a13a75b576d808192b97cbb4c56c8b9c
commit cd634244a13a75b576d808192b97cbb4c56c8b9c
diff --git a/NEWS.md b/NEWS.md
@@ -16,6 +16,8 @@
 * `ggplotly()` now respects `guide(aes = "none")` (e.g., `guide(fill = "none")`) when constructing legend entries. (#2067)
 * Fixed an issue with translating `GGally::ggcorr()` via `ggplotly()`. (#2012)
 * Fixed an issue where clearing a crosstalk filter would raise an error in the JS console (#2087)
+* Fixed an issue with `{crosstalk}` where running `selectionHandle.clear()` from another visual causes plotly to throw an error. (#2098)
+

 ## Improvements


diff --git a/inst/htmlwidgets/plotly.js b/inst/htmlwidgets/plotly.js
@@ -628,15 +628,15 @@ TraceManager.prototype.updateFilter = function(group, keys) {
 };

 TraceManager.prototype.updateSelection = function(group, keys) {
-  
-  if (keys !== null && !Array.isArray(keys)) {
+
+  if (keys !== null && keys !== undefined  && !Array.isArray(keys)) {
    throw new Error("Invalid keys argument; null or array expected");
  }

  // if selection has been cleared, or if this is transient
  // selection, delete the "selection traces"
  var nNewTraces = this.gd.data.length - this.origData.length;
-  if (keys === null || !this.highlight.persistent && nNewTraces > 0) {
+  if (keys === null || keys === undefined || !this.highlight.persistent && nNewTraces > 0) {
    var tracesToRemove = [];
    for (var i = 0; i < this.gd.data.length; i++) {
      if (this.gd.data[i]._isCrosstalkTrace) tracesToRemove.push(i);
@@ -655,7 +655,7 @@ TraceManager.prototype.updateSelection = function(group, keys) {
    }
  }

-  if (keys === null) {
+  if (keys === null || keys === undefined) {

    Plotly.restyle(this.gd, {"opacity": this.origOpacity});