Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Upgrade to plotly.js 2.0 #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Jun 22, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
d9c7ee0
wip upgrade to plotly.js 2.0
cpsievert Jun 21, 2021
cda64ad
patch plotly.js source to support phantomjs/shinytest
cpsievert Jun 21, 2021
d5982ff
bump mathjax version
cpsievert Jun 21, 2021
f52c111
use npm instead of yarn
cpsievert Jun 21, 2021
cd33241
make geom_bar() default to textposition='none'; approve new vdiffr 0.…
cpsievert Jun 21, 2021
32f491b
Migrate to vdiffr 1.0
cpsievert Jun 21, 2021
3435fbb
Use layout.legend.title over layout.annotations to when converting gu…
cpsievert Jun 21, 2021
d541471
wip migrate to gha
cpsievert Jun 21, 2021
1216874
try npm install
cpsievert Jun 21, 2021
b0f7d16
setup node
cpsievert Jun 21, 2021
e621db1
use recommended node version
cpsievert Jun 21, 2021
a12ad8a
try mac instead
cpsievert Jun 21, 2021
ac249b8
install phantomjs; various cleanup
cpsievert Jun 21, 2021
057fe1f
intentionally break a visual test
cpsievert Jun 21, 2021
88d3c45
fix
cpsievert Jun 21, 2021
38e1bdd
use thematic's approach to testing
cpsievert Jun 21, 2021
177935b
bump version
cpsievert Jun 21, 2021
b056974
Merge branch 'master' into plotlyjs-2.0
cpsievert Jun 21, 2021
bce7053
regenerate snapshots
cpsievert Jun 21, 2021
d37f405
map secrets to env variables
cpsievert Jun 21, 2021
af624bb
accept new gha baselines
cpsievert Jun 21, 2021
f1c39a1
whoops
cpsievert Jun 21, 2021
8de5521
hmm
cpsievert Jun 21, 2021
eed311f
approve shinytest baseline
cpsievert Jun 21, 2021
362b6a4
intentionally break a visual test
cpsievert Jun 21, 2021
6b563bf
always upload
cpsievert Jun 21, 2021
ec40dd8
revert change; new baselines
cpsievert Jun 21, 2021
bd63208
Remove the vdiffr dependency and use testthat snaphots directly
cpsievert Jun 21, 2021
8bd4613
More obvious env var naming
cpsievert Jun 21, 2021
e2fae51
more gha details
cpsievert Jun 21, 2021
be22619
always upload
cpsievert Jun 21, 2021
aa44563
new snaps
cpsievert Jun 21, 2021
a4e306c
intentionally break a visual test (again)
cpsievert Jun 21, 2021
e7c86bb
Revert "intentionally break a visual test (again)"
cpsievert Jun 21, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
approve shinytest baseline
  • Loading branch information
cpsievert committed Jun 21, 2021
commit eed311f44baacf1dff891fbccd3da646a5cbcad5
1 change: 0 additions & 1 deletion 1 .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,3 @@ revdep/
travis_debug.R
.httr-oauth
tests/testthat/Rplots.pdf
inst/examples/shiny/event_data/tests/shinytest/mytest-current/
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"plotly_afterplot-A": "\"plot\"",
"plotly_click-A": "[{\"curveNumber\":0,\"pointNumber\":7,\"x\":24.4,\"y\":3.19,\"customdata\":\"Merc 240D\"}]",
"plotly_hover-A": null,
"plotly_relayout-A": "{\"width\":962,\"height\":400}",
"plotType": "ggplotly"
},
"output": {
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
"plotly_brushing-A": "{\"x\":[23.95978500551268,25.98332414553473],\"y\":[3.0020072289156627,3.5073743975903615]}",
"plotly_click-A": "[{\"curveNumber\":0,\"pointNumber\":7,\"x\":24.4,\"y\":3.19,\"customdata\":\"Merc 240D\"}]",
"plotly_hover-A": null,
"plotly_relayout-A": "{\"width\":962,\"height\":400}",
"plotly_selected-A": "[{\"curveNumber\":0,\"pointNumber\":7,\"x\":24.4,\"y\":3.19,\"customdata\":\"Merc 240D\"}]",
"plotly_selecting-A": "[{\"curveNumber\":0,\"pointNumber\":7,\"x\":24.4,\"y\":3.19,\"customdata\":\"Merc 240D\"}]",
"plotType": "ggplotly"
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"plotly_click-A": null,
"plotly_deselect-A": "\"plot\"",
"plotly_hover-A": null,
"plotly_relayout-A": "{\"width\":962,\"height\":400}",
"plotly_selected-A": null,
"plotly_selecting-A": null,
"plotType": "ggplotly"
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.